public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Chris Metcalf <cmetcalf@tilera.com>
To: <libc-ports@sourceware.org>
Subject: [PATCH] tile: don't guard setting abi- variables with ifeq ($(subdir),misc)
Date: Wed, 30 May 2012 23:34:00 -0000	[thread overview]
Message-ID: <201205302334.q4UNYJGl011555@farm-0002.internal.tilera.com> (raw)

---
Joseph, you may want to check how mips is doing this, since I originally
copied the "make" support from mips.  It worked fine to create syscall.h,
but it was missing out on creating the multiple versions of stub.h,
until I removed the $(subdir) guard, which presumably is somewhat pointless
when we're just setting some variables anyway.  I note that the new arm
support doesn't use a $(subdir) guard either.

 ChangeLog.tile                               |    3 +++
 sysdeps/unix/sysv/linux/tile/tilegx/Makefile |    4 ----
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/ChangeLog.tile b/ChangeLog.tile
index 3d52040..ce8c3e0 100644
--- a/ChangeLog.tile
+++ b/ChangeLog.tile
@@ -1,5 +1,8 @@
 2012-05-30  Chris Metcalf  <cmetcalf@tilera.com>
 
+	* sysdeps/unix/sysv/linux/tile/tilegx/Makefile: Remove test
+	that $(subdir) is "misc" when setting abi- variables.
+
 	* sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/Makefile: New file.
 	* sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/Makefile: New file.
 
diff --git a/sysdeps/unix/sysv/linux/tile/tilegx/Makefile b/sysdeps/unix/sysv/linux/tile/tilegx/Makefile
index f21610c..4f101f3 100644
--- a/sysdeps/unix/sysv/linux/tile/tilegx/Makefile
+++ b/sysdeps/unix/sysv/linux/tile/tilegx/Makefile
@@ -1,10 +1,6 @@
-ifeq ($(subdir),misc)
-
 # Provide biarch definitions.
 abi-variants := 64 32
 abi-64-options := -D__LP64__
 abi-64-condition := __WORDSIZE == 64
 abi-32-options := -U__LP64__
 abi-32-condition := __WORDSIZE == 32
-
-endif
-- 
1.7.1

             reply	other threads:[~2012-05-30 23:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30 23:34 Chris Metcalf [this message]
2012-05-30 23:46 ` Joseph S. Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205302334.q4UNYJGl011555@farm-0002.internal.tilera.com \
    --to=cmetcalf@tilera.com \
    --cc=libc-ports@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).