From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32640 invoked by alias); 27 Jul 2012 22:12:36 -0000 Received: (qmail 32614 invoked by uid 22791); 27 Jul 2012 22:12:35 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SARE_SUB_GETRID,SPF_HELO_PASS,TW_BJ,TW_FC,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Jul 2012 22:12:18 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6RMBoBh026830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 27 Jul 2012 18:11:51 -0400 Received: from redhat.com (vpn-11-123.rdu.redhat.com [10.11.11.123]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6RMBjW5015912 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 27 Jul 2012 18:11:48 -0400 Date: Fri, 27 Jul 2012 22:12:00 -0000 From: Marek Polacek To: Roland McGrath Cc: libc-alpha@sourceware.org, libc-ports , Kaz Kojima , Andreas Krebbel , David Miller Subject: Re: [PATCH] Get rid of ASM_TYPE_DIRECTIVE{,_PREFIX} Message-ID: <20120727221145.GL3311@redhat.com> References: <20120727191849.GJ3311@redhat.com> <20120727202833.25E832C109@topped-with-meat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120727202833.25E832C109@topped-with-meat.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00076.txt.bz2 On Fri, Jul 27, 2012 at 01:28:33PM -0700, Roland McGrath wrote: > I only skimmed but this all looks fine to me. For paranoia's sake, since > this should not change anything, please check that no code changed for i?86 > and x86_64 (eu-elfcmp might suffice, or else objdump -d comparisons). > It should still wait for at least two of sh, powerpc, s390 to report > testing ok. But since this is so mechanical and simple, I'd say if they > are slow (like past the middle of next week, say), commit it anyway and > just remind folks they still need to test. Ok. Looks like no code changed for both i?86 and x86_64: marek@pdp-11 ~/libc-build $ eu-elfcmp -l libc.so.new libc.so eu-elfcmp: libc.so.new libc.so differ: build ID content marek@pdp-11 ~/libc-build $ eu-elfcmp -l ld.so.new elf/ld.so eu-elfcmp: ld.so.new elf/ld.so differ: build ID content Thanks for review, Marek