Re: [PATCH roland/arm-irel-ldsodefs] ARM: add missing #include

[Roland McGrath <roland@hack.frob.com>]

[-- Attachment #1: message body text --]
[-- Type: text/plain, Size: 992 bytes --]

> It's OK and adding missing #includes is one of the types of changes 
> documented at <http://sourceware.org/glibc/wiki/Consensus> as not needing 
> review, but what source file are you building to get this error and what 
> header include order do you see when that file is built?  It looks like 
> (as indicated e.g. by the ordering in the .d files) all the files that end 
> up including dl-irel.h get ldsodefs.h included first for me.

I know it's in the "obvious" category but I wanted to ping you just in case
this was uncovering some subtle problem in my build and you thought it
shouldn't be required.  I'll put it in now since on basic "include what you
use" principles dl-irel.h ought to have the #include.  But it may be
worthwhile to investigate it anyway.

The error hits csu/elf-init.c first, and I think it hit some other files
later.  I've attached elf-init.i from my failing compile in case you want
to puzzle out how its include order differs from yours.

Thanks,
Roland



[-- Attachment #2: elf-init.i.bz2 --]
[-- Type: application/octet-stream, Size: 34575 bytes --]