From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-3046-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 23822 invoked by alias); 9 Aug 2012 23:00:51 -0000
Received: (qmail 23814 invoked by uid 22791); 9 Aug 2012 23:00:49 -0000
X-SWARE-Spam-Status: No, hits=-2.9 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED
X-Spam-Check-By: sourceware.org
Received: from toast.topped-with-meat.com (HELO topped-with-meat.com) (204.197.218.159)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Aug 2012 23:00:37 +0000
Received: by topped-with-meat.com (Postfix, from userid 5281)	id 1D12D2C0CE; Thu,  9 Aug 2012 16:00:36 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <roland@hack.frob.com>
To: "Carlos O'Donell" <carlos@systemhalted.org>
Cc: libc-ports@sourceware.org
Subject: Re: [COMMITTED PATCH] add missing const in arm_gnu_pltexit signature
In-Reply-To: Carlos O'Donell's message of  Thursday, 9 August 2012 18:56:22 -0400 <CADZpyiz2EoubHCpHDEeVuNrP0i8H3sXLQ-qFysOW9AXQBWTSMQ@mail.gmail.com>
References: <20120808215850.048902C0ED@topped-with-meat.com>	<CADZpyiz2EoubHCpHDEeVuNrP0i8H3sXLQ-qFysOW9AXQBWTSMQ@mail.gmail.com>
Message-Id: <20120809230036.1D12D2C0CE@topped-with-meat.com>
Date: Thu, 09 Aug 2012 23:00:00 -0000
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.0 cv=LtfpOghc c=1 sm=1 a=Xls8e6_UBf4A:10		a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=14OXPxybAAAA:8		a=tS2og33jdLwx0T4ajbgA:9 a=CjuIK1q_8ugA:10 a=WkljmVdYkabdwxfqvArNOQ==:117
X-IsSubscribed: yes
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00087.txt.bz2

> I did a quick scan of all the other targets and noticed something I
> thought was odd...

Not so odd, but you remind me that sotruss-lib.c needs the same treatment
the other audit stuff got to move machine-dependent bits into sysdeps files.

> Why do sh, sparc, mips, m68k, ia64, alpha use `const struct La_sh_regs
> *' for ARCH_PLTENTER_MEMBERS?
> 
> Shouldn't that set of register be modifiable by the called audit function?

Yes, I think it should be modifiable and those signatures are wrong.
Clearly we'd be well-served by a test of an audit module with a pltenter
function that actually does something.