Re: [PATCH] hppa: add missing prlimit64 symbol

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: Text/Plain, Size: 1616 bytes --]

On Thursday 12 April 2012 23:58:54 Roland McGrath wrote:
> > sysdeps/unix/sysv/linux/wordsize-64/syscalls.list lists it
> > unconditionally (for the alias), and from there, it seems that all the
> > 32bit arches add it to their arch-specific list.
> 
> That should mean that adding it to sysdeps/unix/sysv/linux/syscalls.list
> should do the right thing for hppa, and that removing it from other
> machine-specific syscalls.list files will then have no effect on the status
> quo.  Can you try that and verify?

ok, i confused myself.  wordsize-64/syscalls.list has the line:
prlimit     EXTRA   prlimit64   i:iipp  prlimit     prlimit64

while the 32bit arches have:
prlimit64   EXTRA   prlimit64   i:iipp  prlimit64

and additionally, we have:
sysdeps/unix/sysv/linux/prlimit.c

so if we try to build a 64bit system with both these syscalls.list entries, we 
hit a build error:
/usr/local/src/gnu/glibc/build/x86_64/libc_pic.a(prlimit64.os): In function 
`prlimit64':
/usr/local/src/gnu/glibc/misc/../sysdeps/unix/syscall-template.S:81: multiple 
definition of `__GI_prlimit64'
/usr/local/src/gnu/glibc/build/x86_64/libc_pic.a(prlimit.os):/usr/local/src/gnu/glibc/misc/../sysdeps/unix/syscall-
template.S:81: first defined here

which makes sense as normally we don't generate a prlimit64 file at all, just a 
prlimit wrapper with a prlimit64 alias in it.

so the next thing i tried was creating 
sysdeps/unix/sysv/linux/wordsize-32/syscalls.list and adding the new prlimit 
alias there.  but a simple i686 build doesn't pick up the new location of the 
prlimit64 symbol.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]