From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12782 invoked by alias); 15 Aug 2012 01:38:53 -0000 Received: (qmail 12770 invoked by uid 22791); 15 Aug 2012 01:38:53 -0000 X-SWARE-Spam-Status: No, hits=-8.6 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,TW_FN,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Aug 2012 01:38:39 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 994041B4060; Wed, 15 Aug 2012 01:38:38 +0000 (UTC) From: Mike Frysinger To: Roland McGrath Subject: Re: [PATCH v2] arm: handle unaligned ABS relocs Date: Wed, 15 Aug 2012 01:38:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.5.0; KDE/4.6.5; x86_64; ; ) Cc: libc-ports@sourceware.org, "Joseph S. Myers" References: <201112121920.17908.vapier@gentoo.org> <1344750618-13673-1-git-send-email-vapier@gentoo.org> <20120814214846.E13362C0E5@topped-with-meat.com> In-Reply-To: <20120814214846.E13362C0E5@topped-with-meat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart44856538.p1xdkUSiCv"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201208142138.41574.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00123.txt.bz2 --nextPart44856538.p1xdkUSiCv Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1248 On Tuesday 14 August 2012 17:48:46 Roland McGrath wrote: > > + Elf32_Addr x; > > + } __attribute__((packed, may_alias)); >=20 > We put a space between __attribute__ and ((. committed this: diff --git a/ports/ChangeLog.arm b/ports/ChangeLog.arm index 6775af4..9434a53 100644 --- a/ports/ChangeLog.arm +++ b/ports/ChangeLog.arm @@ -1,5 +1,9 @@ 2012-08-12 Mike Frysinger =20 + * sysdeps/arm/dl-machine.h (elf_machine_rel) [R_ARM_ABS32]: Fix style. + +2012-08-12 Mike Frysinger + * sysdeps/arm/dl-machine.h (elf_machine_rel) [R_ARM_ABS32]: Declare a new unaligned struct. Cast reloc_addr to that when updating the value it points to. diff --git a/ports/sysdeps/arm/dl-machine.h b/ports/sysdeps/arm/dl-machine.h index ca66e83..343a83e 100644 --- a/ports/sysdeps/arm/dl-machine.h +++ b/ports/sysdeps/arm/dl-machine.h @@ -416,7 +416,7 @@ elf_machine_rel (struct link_map *map, const Elf32_Rel = *reloc, struct unaligned { Elf32_Addr x; - } __attribute__((packed, may_alias)); + } __attribute__ ((packed, may_alias)); # ifndef RTLD_BOOTSTRAP /* This is defined in rtld.c, but nowhere in the static libc.a; make the reference weak so static programs can --nextPart44856538.p1xdkUSiCv Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJQKv2hAAoJEEFjO5/oN/WBy4YQALm18/afWZhbmNYQeOJmt/2v kU++mniMONBK2M+TucrhfLTDWc0AhuFKpw2PONXE6pYWUVBrnWF+tAxfjgm//ZLJ EZsZ+UMQLEXieGbMCZ1zv8S5VfWYzaeyr/hf62hQU6OeRY+R0s4AigKSw4Tdphy9 sxbSkdzouIwJ0DsRBHuEwpUBuhtSQnUuZZaK2uQKo6WWvy7d4LoQXmzVONAtKTZx 4K6wVHeRoWFK53PcBEikCy1FrQdPuPuypstnROHT7M1oXl0MfCJEDoesPzXkHudA +7oWAhgRr/eNSlaHO3JGLXCKeIxxVSp32A9JsC0PLudRaD6lzSikrRP1MbsN9eM8 0Pc51L9JquKra5H/SfZMRrO4YOMTVqfcdk3pWTMf/8lMXMzxxsblFg2YE9lX7gkT k30xiSRilkyXXgxw7cGOHKFokVawEtwzd1MHXqE6jQxdvEJ+XEKm9K7fl8IDzQcH kYXQ5f6Hk9U09eNjfFh7rxf4QocNGa8SIh0WTDswKQa8BPaKXdCxAN9uf9pBTAUj aCZyMgQJDRiHTpiEqx//is9C829tYvMdLqjD4slU+SszRK5w5sS0tq3O7GfZaX10 OQBkrlRXAW23g/m2rsM5Q2BiqFf0zkFaxh9dhHcUWpZbaEZr0qlRWIjdJp0HnzAx WZY8ZYJIyVmDTKUX4RKm =2rUL -----END PGP SIGNATURE----- --nextPart44856538.p1xdkUSiCv--