From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 462 invoked by alias); 15 Aug 2012 16:27:01 -0000 Received: (qmail 339 invoked by uid 22791); 15 Aug 2012 16:26:56 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from toast.topped-with-meat.com (HELO topped-with-meat.com) (204.197.218.159) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Aug 2012 16:26:39 +0000 Received: by topped-with-meat.com (Postfix, from userid 5281) id B74982C0F2; Wed, 15 Aug 2012 09:26:37 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Maxim Kuvyrkov Cc: Andrew Haley , David Miller , "Joseph S. Myers" , Richard Sandiford , , GLIBC Devel , Chris Metcalf Subject: Re: [PATCH] Unify pthread_spin_[try]lock implementations. In-Reply-To: Maxim Kuvyrkov's message of Wednesday, 15 August 2012 15:16:57 +1200 <36A2FFD8-0C98-4AB6-8C64-2EEC5CC67A63@codesourcery.com> References: <65B470D2-4D01-4BA1-AEC5-A72C0006EA22@codesourcery.com> <20120711081441.73BB22C093@topped-with-meat.com> <20120711.012509.1325789838255235021.davem@davemloft.net> <4FFD3CD9.4030206@redhat.com> <84304C03-6A49-4263-9016-05486EDC0E98@codesourcery.com> <4FFD4114.9000806@redhat.com> <20120711112235.B28CA2C099@topped-with-meat.com> <7FBB4F87-9FF3-4239-818F-5A38C8094011@codesourcery.com> <20120725181300.DD1812C0B5@topped-with-meat.com> <36A2FFD8-0C98-4AB6-8C64-2EEC5CC67A63@codesourcery.com> Message-Id: <20120815162637.B74982C0F2@topped-with-meat.com> Date: Wed, 15 Aug 2012 16:27:00 -0000 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.0 cv=LtfpOghc c=1 sm=1 a=IOX5nZC-PoQA:10 a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=14OXPxybAAAA:8 a=YrYOFrqlsOIA:10 a=lzDhS8hmAAAA:8 a=mjKQ8HFdYqwgd6kdcmsA:9 a=CjuIK1q_8ugA:10 a=3dWWJ1Qilv0A:10 a=WkljmVdYkabdwxfqvArNOQ==:117 X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00127.txt.bz2 > 2012-07-09 Maxim Kuvyrkov The indentation here is funny so I don't know if that's just how you were quoting the fragment in the message or if you meant to indent the header line in ChangeLog (which you should not). Remember to use the date of commit in the header line. > * nptl/pthread_spin_lock.c: New file. > * nptl/pthread_spin_trylock.c: New file. These go in nptl/ChangeLog and don't get the "nptl/" prefix. > ports/ These go in the separate ChangeLog.{arm,hppa,m68k,mips} files. >From the way you quoted the fragments it wasn't clear if that's what you meant. > +#define SPIN_LOCK_READS_BETWEEN_CMPXCHG 1000 > +#include_next You don't use #include_next when you're giving the exact full file name like this. Just use #include. Aside from the log nits, the generic additions look fine to me. You can commit those as soon as one of the affected machine's maintainers agrees. For each machine, the changes need to be approved by that machine's maintainer. I'm not the maintainer for any those machines, but I would be inclined to insist that each definition of SPIN_LOCK_READS_BETWEEN_CMPXCHG have a comment giving the machine-specific rationale for the choice of value. I wouldn't wait for all the machine maintainers before committing the generic parts and whichever machine(s) are approved first. Each machine's bits can come along later as those approvals arrive. Thanks, Roland