From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32265 invoked by alias); 15 Aug 2012 16:44:07 -0000 Received: (qmail 32089 invoked by uid 22791); 15 Aug 2012 16:44:03 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from toast.topped-with-meat.com (HELO topped-with-meat.com) (204.197.218.159) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Aug 2012 16:43:51 +0000 Received: by topped-with-meat.com (Postfix, from userid 5281) id 7BE932C105; Wed, 15 Aug 2012 09:43:50 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Maxim Kuvyrkov Cc: Andrew Haley , David Miller , "Joseph S. Myers" , Richard Sandiford , , GLIBC Devel , Chris Metcalf Subject: Re: [PATCH] Unify pthread_spin_[try]lock implementations. In-Reply-To: Maxim Kuvyrkov's message of Thursday, 16 August 2012 04:39:01 +1200 References: <65B470D2-4D01-4BA1-AEC5-A72C0006EA22@codesourcery.com> <20120711081441.73BB22C093@topped-with-meat.com> <20120711.012509.1325789838255235021.davem@davemloft.net> <4FFD3CD9.4030206@redhat.com> <84304C03-6A49-4263-9016-05486EDC0E98@codesourcery.com> <4FFD4114.9000806@redhat.com> <20120711112235.B28CA2C099@topped-with-meat.com> <7FBB4F87-9FF3-4239-818F-5A38C8094011@codesourcery.com> <20120725181300.DD1812C0B5@topped-with-meat.com> <36A2FFD8-0C98-4AB6-8C64-2EEC5CC67A63@codesourcery.com> <20120815162637.B74982C0F2@topped-with-meat.com> Message-Id: <20120815164350.7BE932C105@topped-with-meat.com> Date: Wed, 15 Aug 2012 16:44:00 -0000 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.0 cv=LtfpOghc c=1 sm=1 a=IOX5nZC-PoQA:10 a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=14OXPxybAAAA:8 a=YrYOFrqlsOIA:10 a=wdFcS5xbko0b0CQbFasA:9 a=CjuIK1q_8ugA:10 a=WkljmVdYkabdwxfqvArNOQ==:117 X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00132.txt.bz2 > This is just an indentation artifact in git commit log. It will be > properly formatted in the actual ChangeLog file. OK. Note that we don't use long things like ChangeLog fragments for the git commit messages, just a short subject line. > The machine-specific pthread_spin_lock.c files go to > ports/sysdeps//nptl/pthread_spin_lock.c, which comes first in > sysdeps search path before the generic nptl/pthread_spin_lock.c. So it > is either '#include_next ' or '#include > "../../../../nptl/pthread_spin_lock.c"'. The former looks less ugly than > the later. Hmm. Last I knew #include_next from a main source file didn't work as you expect. Did GCC change? Thanks, Roland