From: Roland McGrath <roland@hack.frob.com>
To: Steve Ellcey <sellcey@mips.com>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>,
<libc-ports@sourceware.org>
Subject: Re: [patch, mips] Fix stubs files for hard float vs. soft float
Date: Tue, 23 Oct 2012 22:48:00 -0000 [thread overview]
Message-ID: <20121023224821.DA5B52C09F@topped-with-meat.com> (raw)
In-Reply-To: Steve Ellcey's message of Tuesday, 23 October 2012 15:14:08 -0700 <1351030448.15035.25.camel@ubuntu-sellcey>
> OK, so I'll get rid of the #else/ERROR lines and then have the script
> print an error message and 'exit 1' if default_abi does not get set.
> That should also catch problems where the CC fails to execute or aborts
> for some reason.
Use a chain of AC_PREPROC_IFELSE or AC_COMPILE_IFELSE instead.
Use AC_MSG_ERROR for the failure case.
> > Why does this need to be in preconfigure instead of configure?
>
> It doesn't have to be. I just put it there because that script was
> already using CC and CFLAGS. Is there are reason why it shouldn't
> be there?
preconfigure is absolutely only for things that must be there.
That is, things that affect the sysdeps directory selection.
> I guess I could put it in ports/sysdeps/unix/sysv/linux/mips/configure.in
> instead since the Makefile that includes the generated Makefile is in
> ports/sysdeps/unix/sysv/linux/mips. Would that be better?
Yes, that's the correct place.
Thanks,
Roland
next prev parent reply other threads:[~2012-10-23 22:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 20:15 Steve Ellcey
2012-10-15 21:15 ` Andreas Schwab
2012-10-15 21:23 ` Andreas Schwab
2012-10-15 22:08 ` Joseph S. Myers
2012-10-15 23:06 ` Steve Ellcey
2012-10-15 23:31 ` Joseph S. Myers
2012-10-22 23:31 ` Steve Ellcey
2012-10-22 23:38 ` Joseph S. Myers
2012-10-23 20:20 ` Steve Ellcey
2012-10-23 21:32 ` Roland McGrath
2012-10-23 22:14 ` Steve Ellcey
2012-10-23 22:48 ` Roland McGrath [this message]
2012-10-24 16:19 ` Steve Ellcey
2012-10-24 16:37 ` Andreas Schwab
2012-10-24 17:13 ` Steve Ellcey
2012-10-24 17:25 ` Roland McGrath
2012-10-25 0:00 ` Steve Ellcey
2012-10-25 12:41 ` Joseph S. Myers
2012-10-25 20:36 ` Steve Ellcey
2012-10-26 21:06 ` Steve Ellcey
2012-10-26 22:11 ` Joseph S. Myers
2012-10-26 23:00 ` Roland McGrath
2012-10-24 16:41 ` Joseph S. Myers
2012-10-24 0:05 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023224821.DA5B52C09F@topped-with-meat.com \
--to=roland@hack.frob.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=sellcey@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).