From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10625 invoked by alias); 23 Oct 2012 22:48:26 -0000 Received: (qmail 10603 invoked by uid 22791); 23 Oct 2012 22:48:25 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from toast.topped-with-meat.com (HELO topped-with-meat.com) (204.197.218.159) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Oct 2012 22:48:22 +0000 Received: by topped-with-meat.com (Postfix, from userid 5281) id DA5B52C09F; Tue, 23 Oct 2012 15:48:21 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Steve Ellcey Cc: "Joseph S. Myers" , Subject: Re: [patch, mips] Fix stubs files for hard float vs. soft float In-Reply-To: Steve Ellcey's message of Tuesday, 23 October 2012 15:14:08 -0700 <1351030448.15035.25.camel@ubuntu-sellcey> References: <1350342376.2044.41.camel@ubuntu-sellcey> <1350948702.15035.5.camel@ubuntu-sellcey> <1351023590.15035.14.camel@ubuntu-sellcey> <20121023213216.B0F222C0A2@topped-with-meat.com> <1351030448.15035.25.camel@ubuntu-sellcey> Message-Id: <20121023224821.DA5B52C09F@topped-with-meat.com> Date: Tue, 23 Oct 2012 22:48:00 -0000 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.0 cv=LtfpOghc c=1 sm=1 a=-COW8kBwH0IA:10 a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=14OXPxybAAAA:8 a=MSnT7BQQMx0A:10 a=uiKMm9caepH7kLxgY1gA:9 a=CjuIK1q_8ugA:10 a=WkljmVdYkabdwxfqvArNOQ==:117 X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00051.txt.bz2 > OK, so I'll get rid of the #else/ERROR lines and then have the script > print an error message and 'exit 1' if default_abi does not get set. > That should also catch problems where the CC fails to execute or aborts > for some reason. Use a chain of AC_PREPROC_IFELSE or AC_COMPILE_IFELSE instead. Use AC_MSG_ERROR for the failure case. > > Why does this need to be in preconfigure instead of configure? > > It doesn't have to be. I just put it there because that script was > already using CC and CFLAGS. Is there are reason why it shouldn't > be there? preconfigure is absolutely only for things that must be there. That is, things that affect the sysdeps directory selection. > I guess I could put it in ports/sysdeps/unix/sysv/linux/mips/configure.in > instead since the Makefile that includes the generated Makefile is in > ports/sysdeps/unix/sysv/linux/mips. Would that be better? Yes, that's the correct place. Thanks, Roland