From: Mike Frysinger <vapier@gentoo.org>
To: Andreas Jaeger <aj@suse.com>
Cc: "libc-ports@sourceware.org" <libc-ports@sourceware.org>
Subject: Re: Patch: Convert ia64 to use <bits/fcntl-linux.h>
Date: Wed, 24 Oct 2012 20:28:00 -0000 [thread overview]
Message-ID: <201210241628.04405.vapier@gentoo.org> (raw)
In-Reply-To: <50883CBE.60805@suse.com>
[-- Attachment #1: Type: Text/Plain, Size: 814 bytes --]
On Wednesday 24 October 2012 15:08:46 Andreas Jaeger wrote:
> #define F_GETLK 5 /* Get record locking info. */
> #define F_SETLK 6 /* Set record locking info (non-blocking). */
> #define F_SETLKW 7 /* Set record locking info (blocking). */
pretty sure these three can get deleted too
> #define F_SETLK64 6 /* Set record locking info (non-blocking). */
> #define F_SETLKW64 7 /* Set record locking info (blocking). */
for these three, i wonder if we could make bits/fcntl-linux.h smarter. like:
#ifndef F_GETLK64
# if __O_LARGEFILE
<current defines to 12/13/14>
# else
<new defines to the non-64bit versions>
# endif
#endif
we'd have to tweak the logic so F_GETLK also does:
#ifndef F_GETLK
# if !defined __USE_FILE_OFFSET64 && __O_LARGEFILE
<current defines to 5/6/7>
...
the rest looks fine
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-10-24 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 19:08 Andreas Jaeger
2012-10-24 20:28 ` Mike Frysinger [this message]
2012-10-25 6:06 ` Andreas Jaeger
2012-10-25 16:38 ` Mike Frysinger
2012-10-27 12:01 ` Andreas Jaeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210241628.04405.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=aj@suse.com \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).