From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3569 invoked by alias); 14 Dec 2012 15:52:05 -0000 Received: (qmail 3556 invoked by uid 22791); 14 Dec 2012 15:52:03 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,TW_EG X-Spam-Check-By: sourceware.org Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Dec 2012 15:51:56 +0000 Received: from farm-0002.internal.tilera.com (10.2.0.32) by USMAEXCH2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server (TLS) id 14.0.694.0; Fri, 14 Dec 2012 10:51:55 -0500 Received: (from cmetcalf@localhost) by farm-0002.internal.tilera.com (8.14.4/8.12.11/Submit) id qBEFpsJe000377; Fri, 14 Dec 2012 10:51:54 -0500 Message-ID: <201212141551.qBEFpsJe000377@farm-0002.internal.tilera.com> From: Chris Metcalf Date: Fri, 14 Dec 2012 15:52:00 -0000 Subject: [PATCH] tile: fix DWARF bug in clone() for created thread To: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00045.txt.bz2 [David - this is pretty low risk (just adds one DWARF CFI directive), but also fixes a pretty minor bug. So your call as to whether I should wait for 2.18 to commit.] Previously, we would see a bad frame in the gdb backtrace output, e.g.: (gdb) bt #0 foo () at foo.c:5 #1 0x000000aaaab68ee8 in start_thread () from /lib/libpthread.so.0 #2 0x000000aaaad01c88 in clone () from /lib/libc.so.6 #3 0x0000000000000000 in ?? () With this change the bogus frame #3 is gone and we have the same output as x86 does for the same program. 2012-12-14 Chris Metcalf * sysdeps/unix/sysv/linux/tile/nptl/clone.S: Fix DWARF info. diff --git a/ports/sysdeps/unix/sysv/linux/tile/nptl/clone.S b/ports/sysdeps/unix/sysv/linux/tile/nptl/clone.S index de4fa13..27592cc 100644 --- a/ports/sysdeps/unix/sysv/linux/tile/nptl/clone.S +++ b/ports/sysdeps/unix/sysv/linux/tile/nptl/clone.S @@ -160,6 +160,8 @@ ENTRY (__clone) r32: the user function pointer */ .Lthread_start: + cfi_def_cfa_offset (FRAME_SIZE) + cfi_undefined (lr) /* Check and see if we need to reset the PID, which we do if CLONE_THREAD isn't set, i.e. we're not staying in the thread group. If CLONE_VM is set, we're doing some kind of thread-like clone, @@ -167,7 +169,6 @@ ENTRY (__clone) in getpid(). Otherwise (if CLONE_VM isn't set), it's a fork-like clone, and we go ahead and write the cached values from the true system pid (retrieved via __NR_getpid syscall). */ - cfi_def_cfa_offset (FRAME_SIZE) #ifdef __tilegx__ { moveli r0, hw1_last(CLONE_VM) -- 1.7.10.3