From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16437 invoked by alias); 8 Feb 2013 00:08:02 -0000 Received: (qmail 16423 invoked by uid 22791); 8 Feb 2013 00:08:01 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from toast.topped-with-meat.com (HELO topped-with-meat.com) (204.197.218.159) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Feb 2013 00:07:56 +0000 Received: by topped-with-meat.com (Postfix, from userid 5281) id B61082C098; Thu, 7 Feb 2013 16:07:54 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: "Joseph S. Myers" Cc: , Subject: Re: Add CFI information for MIPS assembly sources In-Reply-To: Joseph S. Myers's message of Thursday, 7 February 2013 22:52:35 +0000 References: Message-Id: <20130208000754.B61082C098@topped-with-meat.com> Date: Fri, 08 Feb 2013 00:08:00 -0000 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.0 cv=Fp1+DxXq c=1 sm=1 a=YJ4qjWSiqfMA:10 a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=14OXPxybAAAA:8 a=gqYjRa9tbD4A:10 a=nxqkGfa19qlTl-fMV7YA:9 a=CjuIK1q_8ugA:10 a=WkljmVdYkabdwxfqvArNOQ==:117 X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00009.txt.bz2 > For SETUP_GP64 and RESTORE_GP64, the cfi_* directives are in the > individual .S files rather than the macro definitions because the > macros can be used to save the old gp value in either a register or a > stack slot, and those need different CFI directives, so a single macro > SETUP_GP64 can't handle both cases and generate CFI at the same time. It seems much cleaner to define two pairs of macros for the two cases, so that the macros can contain the CFI details too. Separating the code from the CFI like you've done will always be error-prone. Using separate macros is less total text, as well as less duplication of magic numbers. Thanks, Roland