From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22846 invoked by alias); 8 Feb 2013 00:47:23 -0000 Received: (qmail 22837 invoked by uid 22791); 8 Feb 2013 00:47:22 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from toast.topped-with-meat.com (HELO topped-with-meat.com) (204.197.218.159) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Feb 2013 00:47:19 +0000 Received: by topped-with-meat.com (Postfix, from userid 5281) id C3AA12C098; Thu, 7 Feb 2013 16:47:18 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: "Joseph S. Myers" Cc: , Subject: Re: Add CFI information for MIPS assembly sources In-Reply-To: Joseph S. Myers's message of Friday, 8 February 2013 00:41:53 +0000 References: <20130208000754.B61082C098@topped-with-meat.com> Message-Id: <20130208004718.C3AA12C098@topped-with-meat.com> Date: Fri, 08 Feb 2013 00:47:00 -0000 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.0 cv=Fp1+DxXq c=1 sm=1 a=YJ4qjWSiqfMA:10 a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=14OXPxybAAAA:8 a=gqYjRa9tbD4A:10 a=J-sL0n5cj2n7Ixa3EwsA:9 a=CjuIK1q_8ugA:10 a=WkljmVdYkabdwxfqvArNOQ==:117 X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00012.txt.bz2 > Unfortunately sys/asm.h is an installed header implementing some > externally-defined SGI API, but also used internally in glibc for various > things. So the CFI in start/end of function macros there is using > implementation-namespace __mips_cfi_* macros (existing practice for other > architectures being to put CFI in the start/end of function macros), > defined conditionally on _LIBC, and any variation on SETUP_GP64 would I > suppose also need to be in the implementation namespace or conditioned on > _LIBC. (For a non-architecture-specific header you might have an internal > include/sys/asm.h for internal macros, but that's not an option here. Or > put the variants in sysdep.h, but that's separating macros from > closely-related other macros.) For other similar reasons I've been considering supporting sysdeps/.../include/ directories. Those would be in the -I list for building libc, but not in sysdirs and so not candidates for installation. I can do the makefile hackery if you'd like to use that. > (Putting CFI within those macros would also then bring in the need to deal > with CFI for inline asm in the same patch - those macros are used, > stringized, in inline asm in dl-machine.h and dl-trampoline.c, which would > then need at least .cfi_startproc/.cfi_endproc for the functions defined > in inline asm. So it would also make it harder to get in useful pieces of > CFI incrementally without needing to add all the CFI for all of glibc at > once.) Then if it were me I'd just leave out the SETUP_GP* cases in the first patch and leave them for after the blocking issues were cleared out in further incremental changes. Thanks, Roland