From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10349 invoked by alias); 17 May 2013 00:43:50 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 10331 invoked by uid 89); 17 May 2013 00:43:49 -0000 X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,TW_HW autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from toast.topped-with-meat.com (HELO topped-with-meat.com) (204.197.218.159) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 17 May 2013 00:43:49 +0000 Received: by topped-with-meat.com (Postfix, from userid 5281) id B2CD02C086; Thu, 16 May 2013 17:43:47 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Edjunior Barbosa Machado Cc: carlos@redhat.com, aj@suse.com, libc-alpha@sourceware.org, libc-ports@sourceware.org, naveen.n.rao@linux.vnet.ibm.com Subject: Re: [PATCH] Update bits/siginfo.h with Linux hwpoison SIGBUS changes In-Reply-To: Edjunior Barbosa Machado's message of Wednesday, 15 May 2013 03:51:23 -0300 <1368600683-11773-1-git-send-email-emachado@linux.vnet.ibm.com> References: <5192A25A.1060406@redhat.com> <1368600683-11773-1-git-send-email-emachado@linux.vnet.ibm.com> Message-Id: <20130517004347.B2CD02C086@topped-with-meat.com> Date: Fri, 17 May 2013 00:43:00 -0000 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=LYSvtFvi c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=14OXPxybAAAA:8 a=ev5S_xOl9skA:10 a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=Z1QoJd9KJfYA:10 a=UBxhwE_8T3GkFFa-rVQA:9 a=CjuIK1q_8ugA:10 X-SW-Source: 2013-05/txt/msg00079.txt.bz2 Always write 'short int', never just 'short'. Otherwise these seem fine to me (assuming they match the new kernel definitions). The ports changes technically need pro forma sign-off from four maintainers. But I think it's good enough if you've triple-checked that the new definitions match the kernel's for each machine, and wait a few days to give them a chance to speak up, but go ahead and commit (say, on Tuesday) for each port whose maintainer hasn't responded. You can commit the common change now (and each port's change as soon as the maintainer says), or wait to do them all together, at your pleasure. Thanks, Roland