From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3607 invoked by alias); 21 May 2013 07:16:26 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 3560 invoked by uid 89); 21 May 2013 07:16:26 -0000 X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,FRT_OFFER2,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 21 May 2013 07:16:25 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4L7GOKg020753 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 21 May 2013 03:16:24 -0400 Received: from spoyarek.pnq.redhat.com (dhcp193-162.pnq.redhat.com [10.65.193.162]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4L7GJAZ009805 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 21 May 2013 03:16:22 -0400 Date: Tue, 21 May 2013 07:16:00 -0000 From: Siddhesh Poyarekar To: Andreas Jaeger Cc: libc-alpha@sourceware.org, libc-ports@sourceware.org Subject: [all-arch-ping][BZ #15465] Avoid crashing with LD_DEBUG=symbols when program name is unavailable Message-ID: <20130521071807.GE8927@spoyarek.pnq.redhat.com> References: <20130514103124.GN25336@spoyarek.pnq.redhat.com> <51923D97.9010703@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <51923D97.9010703@suse.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-05/txt/msg00089.txt.bz2 Pinging arch maintainers to please test and give feedback on the change so that I can check it in. Thanks, Siddhesh On Tue, May 14, 2013 at 03:35:19PM +0200, Andreas Jaeger wrote: > On 05/14/2013 12:31 PM, Siddhesh Poyarekar wrote: > >Hi, > > > >The program name may be unavailable if the user application tampers > >with argc and argv[]. Some parts of the dynamic linker check this > >while others don't, so this patch consolidates the check and fallback > >into a single macro and updates all users. I have also added a simple > >test to verify the fix and have also verified that this does not > >result in any regressions in the testsuite. > > > >I have made mechanical changes to architectures other than x86 (even > >in ports), that I haven't tested. Could the maintainers test and give > >feedback? > > Wow, the checking was really inconsistent throughout the code. I > reviewed the changes and they look fine to me, > > Andreas > -- > Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) > GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126