From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-4186-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 27759 invoked by alias); 28 May 2013 23:58:49 -0000
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
Received: (qmail 27685 invoked by uid 89); 28 May 2013 23:58:48 -0000
X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED autolearn=ham version=3.3.1
X-Spam-User: qpsmtpd, 2 recipients
Received: from toast.topped-with-meat.com (HELO topped-with-meat.com) (204.197.218.159)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 28 May 2013 23:58:48 +0000
Received: by topped-with-meat.com (Postfix, from userid 5281)	id BA10F2C073; Tue, 28 May 2013 16:58:46 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <roland@hack.frob.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: <libc-alpha@sourceware.org>,    <libc-ports@sourceware.org>
Subject: Re: Link extra-libs consistently with libc and ld.so
In-Reply-To: Joseph S. Myers's message of  Friday, 17 May 2013 23:18:58 +0000 <Pine.LNX.4.64.1305172317400.22690@digraph.polyomino.org.uk>
References: <Pine.LNX.4.64.1305090021040.25137@digraph.polyomino.org.uk>	<Pine.LNX.4.64.1305140032090.10338@digraph.polyomino.org.uk>	<20130517202428.B17DA2C0BE@topped-with-meat.com>	<Pine.LNX.4.64.1305172317400.22690@digraph.polyomino.org.uk>
Message-Id: <20130528235846.BA10F2C073@topped-with-meat.com>
Date: Tue, 28 May 2013 23:58:00 -0000
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.1 cv=LYSvtFvi c=1 sm=1 tr=0		a=WkljmVdYkabdwxfqvArNOQ==:117 a=14OXPxybAAAA:8 a=3y3AoTdKMDIA:10		a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=goRXH4VqcUYA:10		a=lzDhS8hmAAAA:8 a=1tEEg-GGGS4vMO8FXVgA:9 a=CjuIK1q_8ugA:10		a=3dWWJ1Qilv0A:10
X-SW-Source: 2013-05/txt/msg00106.txt.bz2

> 2013-05-17  Joseph Myers  <joseph@codesourcery.com>
> 
> 	* Makefile ($(common-objpfx)linkobj/libc.so): Define
> 	link-libc-deps to empty as target-specific variable.
> 	* Makerules (link-libc-args): New variable.
> 	(libc-for-link): Likewise.
> 	(link-libc-deps): Likewise.
> 	(lib%.so): Depend in $(link-libc-deps).  Link with
> 	$(link-libc-args).

s/in/on/

> +# Target-specific variable setting:
> +$(services:%=$(objpfx)libnss_%.so) $(objpfx)libnsl.so: \
> +	libc-for-link = $(libnsl-libc)

Use two-space indentation for this case.
Otherwise it looks too similar to a target with commands.

The comment should say why it's there, not just what it is.
(The commentary was inadequate before, but this is a good time to improve it.)

> +# Target-specific variable setting:
> +$(services:%=$(objpfx)libnss_%.so): libc-for-link = $(libnss-libc)

Likewise with this comment.


Aside from those tiny cosmetic issues, this looks fine to me.


Thanks,
Roland