From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27430 invoked by alias); 6 Jun 2013 21:36:43 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 27420 invoked by uid 89); 6 Jun 2013 21:36:42 -0000 X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED autolearn=ham version=3.3.1 Received: from shards.monkeyblade.net (HELO shards.monkeyblade.net) (149.20.54.216) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 06 Jun 2013 21:36:41 +0000 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0233E591FFC; Thu, 6 Jun 2013 14:36:39 -0700 (PDT) Date: Thu, 06 Jun 2013 21:36:00 -0000 Message-Id: <20130606.143637.1233536179323434136.davem@davemloft.net> To: cmetcalf@tilera.com Cc: libc-ports@sourceware.org Subject: Re: [PATCH] tile: improve detection for missing -mcmodel=large support From: David Miller In-Reply-To: <51B0ECC9.2060903@tilera.com> References: <519ECAF3.1040700@tilera.com> <51A4F980.3040309@tilera.com> <51B0ECC9.2060903@tilera.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00010.txt.bz2 From: Chris Metcalf Date: Thu, 6 Jun 2013 16:10:49 -0400 > Ping! for David Miller. This is fine to backport to 2.17, thanks. > On 5/28/2013 2:37 PM, Chris Metcalf wrote: >> I pushed this to master. "Ping" for David Miller to comment on 2.17 acceptability. Thanks! >> >> On 5/23/2013 10:05 PM, Chris Metcalf wrote: >>> (Adding David explicitly to Cc.) >>> >>> On 5/23/2013 6:17 PM, Carlos O'Donell wrote: >>>> On 05/23/2013 03:20 PM, Chris Metcalf wrote: >>>>> The existing test avoided passing -mcmodel=large if the compiler didn't >>>>> support it. However, we need to test not just the compiler support, but >>>>> also the toolchain (as and ld) support, so make the test more complete. >>>>> In addition, we have to avoid using the hwN_plt() assembly operators if >>>>> that support is missing, so guard the uses with #ifdef NO_PLT_PCREL. >>>>> >>>>> This allows us to properly build glibc with the current community >>>>> binutils, which doesn't yet have the PC-relative PLT operator support. >>>>> The -mcmodel=large support is in gcc 4.8, but the toolchain support >>>>> won't be present in the community until binutils 2.24. >>>>> --- >>>>> This change should also be applied on the 2.17 release branch for >>>>> when we release a 2.17.1. >>>> No, just backport it immediately after checkin to master. The 2.17 >>>> branch *is* 2.17.1 in development and when we get enough changes in >>>> that branch we cut it and make a 2.17.1 release. >>>> >>>> You need release manager ACK though, which is David Miller. We normally >>>> handle backports via bugzilla bugs with keyword glibc_2.17, but it >>>> can be less formal if you just CC David and ask for ACK. >>> David, is it OK if I backport this to the 2.17 branch after I commit? Do you want a BZ# to track it?