From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11458 invoked by alias); 26 Aug 2013 12:50:01 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 11439 invoked by uid 89); 26 Aug 2013 12:50:01 -0000 Received: from popelka.ms.mff.cuni.cz (HELO popelka.ms.mff.cuni.cz) (195.113.20.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Aug 2013 12:50:00 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,SPF_NEUTRAL autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: popelka.ms.mff.cuni.cz Received: from domone.kolej.mff.cuni.cz (popelka.ms.mff.cuni.cz [195.113.20.131]) by popelka.ms.mff.cuni.cz (Postfix) with ESMTPS id 6148D538A6; Mon, 26 Aug 2013 14:49:55 +0200 (CEST) Received: by domone.kolej.mff.cuni.cz (Postfix, from userid 1000) id B771B5FC15; Mon, 26 Aug 2013 14:49:55 +0200 (CEST) Date: Mon, 26 Aug 2013 12:50:00 -0000 From: =?utf-8?B?T25kxZllaiBCw61sa2E=?= To: Carlos O'Donell Cc: Torvald Riegel , GLIBC Devel , libc-ports Subject: Re: [PATCH] Unify pthread_once (bug 15215) Message-ID: <20130826124955.GA6065@domone.kolej.mff.cuni.cz> References: <1368024237.7774.794.camel@triegel.csb> <519D97E4.4030808@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <519D97E4.4030808@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-SW-Source: 2013-08/txt/msg00045.txt.bz2 On Thu, May 23, 2013 at 12:15:32AM -0400, Carlos O'Donell wrote: > On 05/08/2013 10:43 AM, Torvald Riegel wrote: > > Note that this will make a call to pthread_once that doesn't need to > > actually run the init routine slightly slower due to the additional > > acquire barrier. If you're really concerned about this overhead, speak > > up. There are ways to avoid it, but it comes with additional complexity > > and bookkeeping. > > We want correctness. This is a place where correctness is infinitely > more important than speed. We should be correct first and then we > should argue about how to make it fast. > As pthread_once calls tend to be called once per thread performance is not an issue. > > If there's no objection to the essence of this patch, I'll post another > > patch that actually replaces I1 and I2 with the modified variant in the > > attached patch. > > Please repost. > We wait for new version.