From: Roland McGrath <roland@hack.frob.com>
To: libc-ports@sourceware.org
Subject: [PATCH roland/arm-mcount] ARM: Disable compat mcount code when unneeded.
Date: Tue, 27 Aug 2013 17:30:00 -0000 [thread overview]
Message-ID: <20130827173014.D264D2C097@topped-with-meat.com> (raw)
The obsolete _mcount entry point is not needed in a shared library not
supporting any old ABIs. This change also makes it unavailable for static
linking altogether. We have never supported linking old object files with
new libraries, so that should not be a problem for existing configurations.
Thanks,
Roland
ports/ChangeLog.arm
2013-08-27 Roland McGrath <roland@hack.frob.com>
* sysdeps/arm/arm-mcount.S: #include <shlib-compat.h>.
(_mcount, mcount):
Protect under [SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_19)].
--- a/ports/sysdeps/arm/arm-mcount.S
+++ b/ports/sysdeps/arm/arm-mcount.S
@@ -65,6 +65,10 @@ ENTRY(__gnu_mcount_nc)
END(__gnu_mcount_nc)
+#include <shlib-compat.h>
+
+#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_19)
+
/* Provide old mcount for backwards compatibility. This requires
code be compiled with APCS frame pointers. */
@@ -102,3 +106,5 @@ END(_mcount)
but some old asm code might assume it's `mcount'. */
#undef mcount
weak_alias (_mcount, mcount)
+
+#endif
next reply other threads:[~2013-08-27 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 17:30 Roland McGrath [this message]
2013-08-29 12:22 ` Joseph S. Myers
2013-08-29 23:27 ` Roland McGrath
2013-08-29 23:45 ` Joseph S. Myers
2014-01-10 21:34 ` Roland McGrath
2014-01-10 21:54 ` Joseph S. Myers
2014-01-10 22:06 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827173014.D264D2C097@topped-with-meat.com \
--to=roland@hack.frob.com \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).