From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1877 invoked by alias); 27 Aug 2013 17:30:18 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 1858 invoked by uid 89); 27 Aug 2013 17:30:18 -0000 Received: from toast.topped-with-meat.com (HELO topped-with-meat.com) (204.197.218.159) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 27 Aug 2013 17:30:18 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: topped-with-meat.com Received: by topped-with-meat.com (Postfix, from userid 5281) id D264D2C097; Tue, 27 Aug 2013 10:30:14 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: libc-ports@sourceware.org Subject: [PATCH roland/arm-mcount] ARM: Disable compat mcount code when unneeded. Message-Id: <20130827173014.D264D2C097@topped-with-meat.com> Date: Tue, 27 Aug 2013 17:30:00 -0000 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=QZT14Krv c=1 sm=1 tr=0 a=WkljmVdYkabdwxfqvArNOQ==:117 a=14OXPxybAAAA:8 a=xi_NrjeCyaoA:10 a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=hOe2yjtxAAAA:8 a=iFL9Sq4dD4AA:10 a=XAG08hrkY_goeeEl1MEA:9 a=CjuIK1q_8ugA:10 X-SW-Source: 2013-08/txt/msg00051.txt.bz2 The obsolete _mcount entry point is not needed in a shared library not supporting any old ABIs. This change also makes it unavailable for static linking altogether. We have never supported linking old object files with new libraries, so that should not be a problem for existing configurations. Thanks, Roland ports/ChangeLog.arm 2013-08-27 Roland McGrath * sysdeps/arm/arm-mcount.S: #include . (_mcount, mcount): Protect under [SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_19)]. --- a/ports/sysdeps/arm/arm-mcount.S +++ b/ports/sysdeps/arm/arm-mcount.S @@ -65,6 +65,10 @@ ENTRY(__gnu_mcount_nc) END(__gnu_mcount_nc) +#include + +#if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_19) + /* Provide old mcount for backwards compatibility. This requires code be compiled with APCS frame pointers. */ @@ -102,3 +106,5 @@ END(_mcount) but some old asm code might assume it's `mcount'. */ #undef mcount weak_alias (_mcount, mcount) + +#endif