public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@hack.frob.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH roland/arm-mcount] ARM: Disable compat mcount code when unneeded.
Date: Thu, 29 Aug 2013 23:27:00 -0000	[thread overview]
Message-ID: <20130829232658.5B2002C072@topped-with-meat.com> (raw)
In-Reply-To: Joseph S. Myers's message of  Thursday, 29 August 2013 12:22:07 +0000 <Pine.LNX.4.64.1308291219461.32214@digraph.polyomino.org.uk>

> Isn't this about objects built with old compilers (before GCC 4.4, when 
> __gnu_mcount_nc was introduced; arm*-*-linux-gnueabi support was added in 
> 4.1), which is generally supported, rather than objects built with old 
> library headers, which isn't?

I see.  I'd still like to find a way to exclude this code from
configurations that will never use it, i.e. a target for which there was
never a compiler that produced _mcount calls.  But perhaps there is no
"generic" way to achieve that.  I suppose I can just move it to a separate
file and let my configuration drop that file from sysdep-routines.

I think the ideal would be if we dropped it from the shared library (except
for a compat_symbol where needed, of course) and had it only in
libc_nonshared.a.  But I can't see a way to e.g. write _mcount in terms of
calling __gnu_mcount_nc (without breaking the profile so that it only
tracks _mcount itself as the callee), and I don't want to expose something
like __mcount_internal in the ABI just so that _mcount can call it.

Can you think of anything better?


Thanks,
Roland

  reply	other threads:[~2013-08-29 23:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27 17:30 Roland McGrath
2013-08-29 12:22 ` Joseph S. Myers
2013-08-29 23:27   ` Roland McGrath [this message]
2013-08-29 23:45     ` Joseph S. Myers
2014-01-10 21:34       ` Roland McGrath
2014-01-10 21:54         ` Joseph S. Myers
2014-01-10 22:06           ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130829232658.5B2002C072@topped-with-meat.com \
    --to=roland@hack.frob.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-ports@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).