From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11738 invoked by alias); 9 Sep 2013 17:46:27 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 11729 invoked by uid 89); 9 Sep 2013 17:46:26 -0000 Received: from popelka.ms.mff.cuni.cz (HELO popelka.ms.mff.cuni.cz) (195.113.20.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Sep 2013 17:46:26 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,SPF_NEUTRAL autolearn=no version=3.3.2 X-HELO: popelka.ms.mff.cuni.cz Received: from domone.kolej.mff.cuni.cz (popelka.ms.mff.cuni.cz [195.113.20.131]) by popelka.ms.mff.cuni.cz (Postfix) with ESMTPS id 86A9969C3A; Mon, 9 Sep 2013 19:46:20 +0200 (CEST) Received: by domone.kolej.mff.cuni.cz (Postfix, from userid 1000) id 6541C5F822; Mon, 9 Sep 2013 19:46:20 +0200 (CEST) Date: Mon, 09 Sep 2013 17:46:00 -0000 From: =?utf-8?B?T25kxZllaiBCw61sa2E=?= To: "Joseph S. Myers" Cc: Will Newton , "libc-ports@sourceware.org" , Patch Tracking Subject: Re: [PATCH v3] ARM: Improve armv7 memcpy performance. Message-ID: <20130909174620.GA32192@domone.kolej.mff.cuni.cz> References: <522D977E.2000906@linaro.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00073.txt.bz2 --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1930 On Mon, Sep 09, 2013 at 05:11:36PM +0000, Joseph S. Myers wrote: > On Mon, 9 Sep 2013, Will Newton wrote: > > > I believe the glibc memcpy benchmark is not capable in its present > > form of showing the difference between this version of the code and > > the current one: > > > > 1. The variety of alignments benchmarked is not adequate > > 2. The variability of the benchmark results is quite high (more runs > > required and page allocation issue) > > 3. The output of the benchmark contains no measure of variance > > 4. There is no means of showing graphically the output of the > > benchmark (for subtle differences this is necessary IMO) > > Please make sure the wiki todo list > includes all > these areas for improvement of the benchmarks. > > > These are all surmountable problems but I would rather not gate > > acceptance of this code on a satisfactory resolution of the above > > issues. I can provide output from the cortex-strings benchmark quite > > instead though. > > If your summary of the benchmarking discussion indicates that the existing > glibc benchmark is not relevant for the cases addressed by the patch, then > it's indeed appropriate to give such results from another benchmark. > I would prefer get profiling results in arm, I wrote simple tool that measures time and variance of how long it takes gcc to compile with different memcpy versions. For it you need to compile old and new memcpy as separate libraries that will be preloaded. For that you need to compile memcpy as standalone library like gcc -fPIC -shared old_memcpy.S -o old.so gcc -fPIC -shared new_memcpy.S -o new.so and place old.so and new.so to benchmark directory, then run ./benchmark It may take long until variance becomes statistically significant so its better ran overnigth. If you want check another command copy and modify benchmark script. --LQksG6bCIzRHxTLp Content-Type: application/octet-stream Content-Disposition: attachment; filename="test_memcpy.tar.bz2" Content-Transfer-Encoding: base64 Content-length: 5706 QlpoOTFBWSZTWbPCfL8ADq9/////////////////7////////8dy1GD3e//+ 8v5Xf3//4A5vu49vK3lRl3Ou3d3Lsdx27vDvXs292aer3KjSpWxWld7z257u vekNEEBAE0anoE0nmoam0mngp5pJ40jSaeSbU9TaajankmmJiGjEYm0INpNo jaTRk8Rpk1GjYkbUD1G1DZRpkAaZGRkNNANCJMTRiaZNAnoEnkNGonmpMT0n lGh6mjIDQPUDQ0AaAA00A0ANPUAABoAAAAAGgAGgyADIhqaZQKaj9R6p+qe0 p6b1UNkgNHtSDRoAGjQANAaDQPUAGjQDTIAGgAAAAAAaAaAAADTIAlMkiCnh ACmMmmiNGmjT1A9QJk0aYNE0xMGg0MgTTCaemg1NMj1AwmhhqMEZGBMAmIwm AACNBobUaeiBoaAaANAyADQGgAYQAAGIAAAGEAAaABoaA0AAMgABoANAGgAA GgJFETINNJhGmmU009DKU8nop+qeNU/VGIxqYnqGENqZAeU9RoGhgjQZPU09 TTRgjQ0GmmEZAGjCGhoNADEDRpoaYivJ4jU657YwjuEFv2gnCwwvE9xhhoY3 lY6Fa/ttGhGqSSTMgDMzaf+PCgRY0l5MIGBwGkNg3njWAMmTIoaerOtGSC5W Z1xBFlgHOc+/PMVU4s4WYz9Z+zobHn7GJ2RjcLnFzN+eo0En3ImwyrRTaEyY LXQwRuMpDtoG9AwyNCZX20nPY6kZOM6uadOcHWHJwRKKBYlyLWZ0Tl7elZhl 6FgIDkmTFM5KywV3X9JmTFMz4HGH3p0FwAwbKBADBmZS3UWvVU67bWlg01qt IzN5bZqKplTMco+Kc6JNKCm1C7iQBcgM3dIyFGGCEkhLJUNXug3QkPEsJOrv PIHT3+jhpOCbJjPIK7iBFK5CqSkZrgGREETz4Y0bFpaL+Ol1OXiYVNLzk7VV 3L31Hz+pupkgRAZqNGOrRPqWkpvXHC1ew5VW0CALTNsnRHJN/opFxXv3QCIF CQzyL6niWb0NkAyu3ZJ7iH/bMPg/jch5IyI4bR/vObNEEiCEaNASAr1JJZB2 pkQLSw3mQosGnwuNRVWcq3Y7hCNltGvd7XY9uzTNkNfEvUxnUPF6fibUVQb4 gOPUBYpuMlFBaWFy/0fbpdXNq3CI1i1WnZn9NnXqb01icK0sEJXvlwQKViAW +YAQYAcJpAlFiFrNIiwQhtJIqsAlIHBUYEXBEE0mxNDcNLWkxA1KhNiER1Cg jhERRRAaA0UMAssQpJiAgTZxbUYiAOuGkp2EqCK0CqYKWQANEBEbFDUAJAcY hohIgOZe2cDrsJVlSiIEiJbAgSj0kZ6iFFHIREyytu4ogB5kMLqJQQNsBtja EIIIQqaQwheqDCVme0WTlogiEES1VaqKRgWQASBeU9MvjbJC1ciQrVatYvr5 nAv2moDAftnMa0EIfemZyYqEIYipTFpGiEaZamM6hOdmuLWHekrUHPbawSmJ YnAyFLgk0OJoMKzl9yFwlRWR9uGFFndhZc6cKeK0WI6FrHt8uXEUeLKdazbI EbtIgVZPZ2dO3pyPi52e7RYpapRwigfweHyepNKyZgZw+GMMbiTkDBf22/kR qxgKb0xBRaOpaDf1QoiLe9TASU0mZCelVWiDNx4+KQZsw6tZGkcowEmBC0LT SiAkREdHwPQ9NjG+f2nOd57n+vczcD3FNttoNNpBKxLjYyAlpf3XBZ48ZAY3 CUJCgtDZzy1a2QojuAUc4iNwv4xs9VwV2xGYj6UtgwkwF3SNKYCgc1lbHd+X QUvLpLPJ59Rxbvk8x5RQiLPGMEx8xkC7vf1IthCBxCFKr1VQqR790qjBmZ/s oI+p6biTiITuCEV3j6aHJoExJLX8mAW30DrNts5dfPamXlyAb4YtDsHAR/zG 2PV0zcQeLAhqKvcxtb6lUGOjSIjHL168003f39wWTPAwZ54OZTSShSqh2DSc oYa9Rv8mw4Rnznj5jxnLTMRDgqIRkwUhRiCdpKdC2wndbR8Lx+bQsUu8Q+Po Ijy7OoiRGAZgwBEjp1JRkb1lcJKmZjJhFv8kZJqS7brGk1DpA3Qhc3eZUzBw VQp02pE+vzew5AxxEUzTmw4kisnwc4OxcRnRpk85CGDJIM0IQYqQZBJjf7yh ZaUhe65LT9myMEQXvbupvuv1v36nTcIOmQK9sKI36s2ZWIOZm6WjQNk4660h KQgIR1cPq0HSNtuoUjuiB08CfSAQHA06wxECyxT3Of0eflF/KYmDwZ4gC2Fv irbVl9IwuVe9HBE4DaaDZYjbU3fkHKSnEzDo4nET77kSCOmNYgzLNIq4GoOF 4OODwcHBM2cOZuXK62qm5lJTbi2tFYoG2ooCXOVQycH+n1XeoAYaEiJv3vqd Hp+t4vR8VqO2v3Ll3WzRC4ujmPdUaOhos+PQoOIZqKUMmj5hQUQs+ohOEkhd c5XC/LDxIZ9gKIotfR1DBjp2UxioRwpRz3q5UtSqZgZ5rTTCNXcmxFzjiBqI 60jBJcyZvzERElugQMhw7M30G6H04ihzQ4EHkHwCvBaIQL9099p0YCcoA95r kEzU7nhJHc6bSlK8W/mmRhK6WHAshquMiRlvAK3W1Xgzh1fjU3PaQenlQd+7 0SbMNZb6BQn0IBQPbpTTSGfIGjFu5tfUhu1yfg1x2atA5z+xUEhbabNpnSBk ONUQiFYBhCHMGWRHjqF+9iieK+C6EXXQLVYYDGdCrWpNKD0bh7L4PGXR0D5i ki+XVA4o9dqC0Ukd+LR0EEQMhLLP2her40BRT7ajNWQjrMwDX3Y1NgwXxRjd 8TCvbrkitd0gOZDTIAQiWYn1gx3N/lMDIm1aUrRx9aaILMoHPzmqrPN3mNI6 7yMnhqMGnK2MbLt1KVogdmCLhIzMob3CGzUEjX/Zzn6v21Z2JXITiIMihiMD i/NS47Aa8s8lYiLYlKhSboD1vusH756QfKgEEASxgg9eN9eQlyXZhUfc7r3Q BEAIMvsDWiJkbqs0d85FJFfB+jb3xoJijCVvXq22XRcAYUGKiTnXtiZrRjYA Fy4CIPUzhtNFZ7xZ2jAi/fPRww+tK3MTMlsliUROpqzuxe4tVjj+r9tZq742 x6DpDY3mxb5CJFtguZrPyGJetjZV10bHq5f2hMtVgMTy8q8gCCEmQrK+v+TR QW2xrHwUOGXX3eHJ2evp3+06/mTIxua+mpl0mNd+KXKt7tMiTTsuoTTi0YPC MGbFovUwCCKclKkimRcKBQZq+StLx6AAiB1DimVWtrLHmZxI2QAg9MQ6d2ns a3zcfv8a8+j+huODWdmv2b3WAhcg5usHRFyIYIaWcBgRY86jUR3umqJcvCER O4mmC5Sn23/Pc8X2DIGRiEIj/escAmcASDdrFsZTu9hj5a1MQlRk1R1xvFqN xFV5EBlyx8QRXZJT/4J9Gw4KSwwcC47RJBs7sIn4Rmagjhw1hykr2RinKl8U V5VoW/44EQPRx1wMlN7ZVIUywDNEdAsHEBxiJNQSUIYSjMEspRVCy24W0IOG WYQ8raINxxgQ0N7GUYDpf0+6+0GhvGgIAwPQ2Z3NdC4Xdgg2hFa5+MbbWyp2 RB8TQrRRnbnLEHoMDdBqenDWnnlPE7nLIodrS1VfryxZvU1m6urtyrut2qKX 9AxrmaHBdXJC3LM+dCQNrh4HCDnSSqZ/B014TALmWb2D0TaXgvv3XG63ouf4 rEoG2JAkzcy/y3Y24/qukDpEGwRGrkcdavgMQ0H0N62G0uRnbfBty1BBpVPO 0oQhDzsrJNyrno0lNgIJupIxFTsT4hD0g1nHHFX5TY+x6vp5n1RokRzzTSTt KylWFkuFVj75gVF81ecT7JvCINUQkk0NCIQkLSsJlQG2jeV964NwgBrn0HbR bGlhB6AdcUhTiM9JrDdTnQw5ER5zr+yxqjaCnQT2S0bCVSoWhYlTpGbvIo7L MHdJgxil6iuyDM1j7PMoGGNRM9Xs6naRkpoO1JQ38MuwpQIfpqGx2QIhSBDI oTHTeGVlTBIJRkj9Fc2dAKZeuqUlw2SmQlLrWjFFAWaTA1VImiYpEYGVIy1B wjYCIjdlElSvrmAVAygKqNGyxjmIsnAlT2wlzQagCeYWSsJEi6vJ1mbpRpgL LRNyDYXVhdejCDOu/WAVFqLr9fuMlbFufpaoFUKBSljC+XYEDMlJibURGEvz ZBMeRuu8WxEK19RGdTaNC2ISZIrfC1cX6qyUgJodMOjeAQHeBaFZSwBie8M8 QkrGZlLZLPriBRNyC82NGAKZFZBBtvT2NhfY0sXpbWybJaQK+MW3OAZNnzyv 5REk1cqWb4cllycMgVQ6BeERlMAnAIMx0P4YdespiYcshLKOIAyZdPLPjDlk bnXn8cxS3EREow6y7SaSsZ2RfsVEs9TcFfbNAikt1lUrSKeIyEgru9IqMoK0 LVIzk8oJloLEdIKm3IK/bIhI1LtyLDSJMQzLetmgVS+TJR3C2qa0SRWygoFY vlDsUq1ZEBmkuJ28uhAiriN/xpAkkpuYcQr4oyG9CBkBikSQSVlt4JQjbCE5 ZFkYw3ZNMK5QzztNQMgSGEgWSWlV1jiV1urMw0FzQLeFixSS4JYgKsZAOkKI IXHAAxZdoUQtWAkLNKlqaKLjAMz3mB9Bm1iuDdOtrVSULEsVXBkiM5UAyJqa solfPhECoVjBECziMTzIH/eQ5vzf6MVUVG7q/ieM1SlTHP0Z0MsvUV9hCTYD AjBVRJhsOh7yCF4RMHZtFymNfsHnC/gVZBg8O0S6JHgIyWAqSVmGU+v9omi6 3oy6bnUL6IqL2phCzSccI7PAlDLO0lJNTfndq62Wdjdc9BMZy7Ak7tzUZYNp QgDVkcNVdyYg2fDU89KlxIE5Z25oFCi6e4GiCBYRIa1mLS3M9rJyT6mpOfQn c0QSQYevaSUCFASm1rvtXKgI8nxLIfgWyvHj6OxYswqSMbTaQ3N1IsmlcwZe Bg3th3VrQ2rURl1I2NnALPD51QhaaYiQILEln+VyvHfBCWywHYflL8mLNvZX F28WU29PmhDQwqKli2gNtnpRTjoOOob0HjsowkgMuqiIajZNTY/L3u86DLC9 KcrKhGYJCBXULiSupfiLtzhsRheqw8lTImOPzlZR7DPCA/Qn+3FkUacPHJeb BBG2tkjaLHIWKYbZ8d+3EGczTAM3MsWkJQIZDK5zsVuG4F6ocCJArGXDBHyT SALkb/v92zQ5RRlxvqt3eFcfEnWIDI7nNSlhRLTuEO3Qj+OdABhGATF/ecXb VcCjPpzpvcswM/aoRXwUmNaFyGAbGUrwfdxlxU3rTqJpWYimwYSrKuU5Vwy2 rRSLp7kYKc45eeelDuny1dSyqkyGc9F97jEqUBUe14VkoQ1hhBTA4wxrwvBs CrHM1Rjbf434bF6/9wsvBNQJV6+0amLGBbrVrEmKpQS+lr+HHs/DjyaCZqdT Y4L8gRO1ssjchGuMzGPTI/vcd9M9aL2YMxA/b/IMfMiD69QzSaZwQlBtUEGV UMIJXw//e0e1mfhblidJEuUsfwl0sPsXQLBaUywEEe1l7PKWZsuJ3TCpYtr2 gcGsm97Q2tvb7WTzP/F3JFOFCQs8J8vw --LQksG6bCIzRHxTLp--