public inbox for
 help / color / mirror / Atom feed
From: Kaz Kojima <>
Subject: Re: All machines: Pointer guard testing update (Bug 15754, CVE-2013-4788).
Date: Fri, 27 Sep 2013 01:06:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


"Carlos O'Donell" <> wrote:
> My request is that you run the testsuite and verify that
> tst-ptrguard1 and tst-ptrguard1-static pass. If they don't
> pass please email me and we can work out what might be
> wrong with your POINTER_CHK_GUARD implementation.

New ptrguard tests fail on SH because the target uses generic
stackguard-macros.h but defines THREAD_SET_POINTER_GUARD.
The attached patch works for me.

	* sysdeps/sh/stackguard-macros.h: New file.

diff --git a/sysdeps/sh/stackguard-macros.h b/sysdeps/sh/stackguard-macros.h
new file mode 100644
index 0000000..55a5771
--- /dev/null
+++ b/sysdeps/sh/stackguard-macros.h
@@ -0,0 +1,6 @@
+#include <stdint.h>
+extern uintptr_t __stack_chk_guard;
+#define STACK_CHK_GUARD __stack_chk_guard

  parent reply	other threads:[~2013-09-27  1:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26 14:52 Carlos O'Donell
2013-09-26 15:39 ` Will Newton
2013-09-26 16:26   ` Richard Henderson
2013-09-27  1:06 ` Kaz Kojima [this message]
2013-09-27  1:43   ` Carlos O'Donell
2013-09-27  2:15     ` Kaz Kojima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).