From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16005 invoked by alias); 27 Sep 2013 01:06:46 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 15991 invoked by uid 89); 27 Sep 2013 01:06:45 -0000 Received: from mo10.iij4u.or.jp (HELO mo.iij4u.or.jp) (210.138.174.78) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Sep 2013 01:06:45 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=4.8 required=5.0 tests=AWL,BAYES_50,FSL_HELO_NON_FQDN_1,HELO_LOCALHOST,RCVD_IN_SORBS_DUL,RDNS_DYNAMIC,SPAM_SUBJECT,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mo.iij4u.or.jp Received: by mo.iij4u.or.jp (mo10) id r8R16aQG009463; Fri, 27 Sep 2013 10:06:36 +0900 Received: from localhost (238.152.138.210.bn.2iij.net [210.138.152.238]) by mbox.iij4u.or.jp (mbox11) id r8R16Zne016442; Fri, 27 Sep 2013 10:06:36 +0900 Date: Fri, 27 Sep 2013 01:06:00 -0000 Message-Id: <20130927.100635.215380609.kkojima@rr.iij4u.or.jp> To: carlos@redhat.com Cc: libc-ports@sourceware.org, thomas@codesourcery.com Subject: Re: All machines: Pointer guard testing update (Bug 15754, CVE-2013-4788). From: Kaz Kojima In-Reply-To: <52444A27.7050500@redhat.com> References: <52444A27.7050500@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00147.txt.bz2 Hi, "Carlos O'Donell" wrote: > My request is that you run the testsuite and verify that > tst-ptrguard1 and tst-ptrguard1-static pass. If they don't > pass please email me and we can work out what might be > wrong with your POINTER_CHK_GUARD implementation. New ptrguard tests fail on SH because the target uses generic stackguard-macros.h but defines THREAD_SET_POINTER_GUARD. The attached patch works for me. Regards, kaz -- * sysdeps/sh/stackguard-macros.h: New file. diff --git a/sysdeps/sh/stackguard-macros.h b/sysdeps/sh/stackguard-macros.h new file mode 100644 index 0000000..55a5771 --- /dev/null +++ b/sysdeps/sh/stackguard-macros.h @@ -0,0 +1,6 @@ +#include + +extern uintptr_t __stack_chk_guard; +#define STACK_CHK_GUARD __stack_chk_guard + +#define POINTER_CHK_GUARD THREAD_GET_POINTER_GUARD()