public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
* Close bug 11615?
@ 2013-10-12 20:05 Ondřej Bílka
  2013-10-12 21:21 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Ondřej Bílka @ 2013-10-12 20:05 UTC (permalink / raw)
  To: David Miller; +Cc: libc-ports

Hi David,

Following patch is for handling broken binaries on mips with RLD_MAP set
to 0. This was caused by bug in binutils which was fixed two years ago,
see. I wanted to be sure that it is no longer relevant.

https://sourceware.org/bugzilla/show_bug.cgi?id=11615

diff --git a/sysdeps/mips/dl-machine.h b/sysdeps/mips/dl-machine.h
index 123b4d6..3bed59c 100644
--- a/sysdeps/mips/dl-machine.h
+++ b/sysdeps/mips/dl-machine.h
@@ -70,7 +70,8 @@
 /* If there is a DT_MIPS_RLD_MAP entry in the dynamic section, fill it
in
    with the run-time address of the r_debug structure  */
 #define ELF_MACHINE_DEBUG_SETUP(l,r) \
-do { if ((l)->l_info[DT_MIPS (RLD_MAP)]) \
+do { if ((l)->l_info[DT_MIPS (RLD_MAP)] && \
+	 (l)->l_info[DT_MIPS (RLD_MAP)]->d_un.d_ptr) \
        *(ElfW(Addr) *)((l)->l_info[DT_MIPS (RLD_MAP)]->d_un.d_ptr) = \
        (ElfW(Addr)) (r); \
    } while (0)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Close bug 11615?
  2013-10-12 20:05 Close bug 11615? Ondřej Bílka
@ 2013-10-12 21:21 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-10-12 21:21 UTC (permalink / raw)
  To: neleai; +Cc: libc-ports

From: Ondřej Bílka <neleai@seznam.cz>
Date: Sat, 12 Oct 2013 22:05:24 +0200

> Following patch is for handling broken binaries on mips with RLD_MAP set
> to 0. This was caused by bug in binutils which was fixed two years ago,
> see. I wanted to be sure that it is no longer relevant.
> 
> https://sourceware.org/bugzilla/show_bug.cgi?id=11615

The binutils bug has been fixed for at least 2 years.  I'd say
it's better not to add this check.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-10-12 21:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-12 20:05 Close bug 11615? Ondřej Bílka
2013-10-12 21:21 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).