From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21693 invoked by alias); 6 Dec 2013 21:12:05 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 21674 invoked by uid 89); 6 Dec 2013 21:12:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp.gentoo.org Received: from Unknown (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 06 Dec 2013 21:12:04 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 7EC5E33F3AD; Fri, 6 Dec 2013 21:11:56 +0000 (UTC) From: Mike Frysinger To: libc-ports@sourceware.org Subject: Re: [RFC][BZ #13690] Always read private before lll_unlock. Date: Fri, 06 Dec 2013 21:12:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.12.1; KDE/4.6.5; x86_64; ; ) Cc: =?utf-8?q?Ond=C5=99ej_B=C3=ADlka?= , Atsushi Nemoto , libc-alpha@sourceware.org References: <20131206190159.GA25502@domone.podge> <20131206194305.GA26401@domone.podge> In-Reply-To: <20131206194305.GA26401@domone.podge> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4067079.XzGHXzx2n3"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201312061611.59957.vapier@gentoo.org> X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00004.txt.bz2 --nextPart4067079.XzGHXzx2n3 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 863 On Friday 06 December 2013 14:43:05 Ond=C5=99ej B=C3=ADlka wrote: > --- /dev/null > +++ b/include/futex_unlock.h probably should live at nptl/lowlevellock_unlock > @@ -0,0 +1,15 @@ > +#define lll_unlock(lock, private) \ all new files need a proper comment header block > + ((void)) ({ \ > + int __private =3D private; \ > + __lll_unlock (lock, __private); \ > + }) > + > +#define lll_unlock(lock, private) \ did i misread, or are both of these macros named "lll_unlock" ? should one= =20 have a __ prefix ? > + ((void) ({ \ > + int *__futex =3D &(lock); \ > + int __val =3D atomic_exchange_rel (__futex, 0); \ > + if (__builtin_expect (__val > 1, 0)) \ > + lll_futex_wake (__futex, 1, private); \ > + })) > + > + no trailing newlines please -mike --nextPart4067079.XzGHXzx2n3 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJSoj2fAAoJEEFjO5/oN/WBFr4P/067NZ588WPjVKUrrn+GK8ZN xzHXpWmexvSCR90NbN2BsMOJdngZzUSHoMlVgrYqKYhnZ0H/OQXkM6BN8JN30l7/ F1+ZEXMrpX6pVgknnqfFAiq9S5Su+Gc1Lw/i7dCkP0AOEgg+ErWsTO9tSSGSc6xE zF1TAnO7WWbZi9a1xNdUhPa4KwM6hI+dXg2j5qt5IkNJLIDfEBXYiRR4WQtgKllZ lOBxWLnypHEJzrv/lvZVBbka996qKndDMdJtlpoOI1v0fgDSAx3csjocH+e9s1HE K7+3E6TVESaoYeqFTzAqkEA7K63cL4bYfU5VCvQ4+rttzdE5DiZiATf5gAoGYAmp HA8LXOQfqVPb5XFXFBGo/5OhVhuma/YAev+gdSDy/myxbg6C8JKgk9JAND4LzgOr jlRv3NvJ5GxwDmDeL10MXYD0It6moJDN/usCjNJpR6Yh2i4q9txfknGfOn/ACgWV XRiQK4JopLFaTMBW90LN2yo5GZVCdVQurSOV62RHVUBZJSUJ5gEnDfd5mnAU6qwT 3BGBkZc5Xqfn/vr6DIvViS6eKWSgNRgU+O3OehMjw/iYiQmlOJR9bLZS4KBMhcfC qDz6KPuC48sczxDR9oC56du9tR+kpspvHHeT1i+/FHlccHzXn7Hgf7kP0usGLe9I aEuoP/u6obN9b0AD3w8W =H9E6 -----END PGP SIGNATURE----- --nextPart4067079.XzGHXzx2n3--