From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1648 invoked by alias); 20 Nov 2013 19:57:56 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 1637 invoked by uid 89); 20 Nov 2013 19:57:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.1 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: multi.imgtec.com Received: from Unknown (HELO multi.imgtec.com) (194.200.65.239) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Nov 2013 19:57:54 +0000 From: Jack Carter To: Will Newton CC: "libc-ports@sourceware.org" , "rdsandiford@googlemail.com" Subject: RE: [PATCH] 2nd round of Mips ifunc support Date: Wed, 20 Nov 2013 21:15:00 -0000 Message-ID: <4CEFBC1BE64A8048869F799EF2D2EEEE4C516E27@BADAG02.ba.imgtec.org> References: <4CEFBC1BE64A8048869F799EF2D2EEEE4C516140@BADAG02.ba.imgtec.org>, In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SEF-Processed: 7_3_0_01192__2013_11_20_19_57_46 X-SW-Source: 2013-11/txt/msg00042.txt.bz2 Will, Thanks for looking at this. My responses are below. Jack ________________________________________ > From: Will Newton [will.newton@linaro.org] > Sent: Saturday, November 16, 2013 3:06 AM > To: Jack Carter > Cc: libc-ports@sourceware.org; rdsandiford@googlemail.com > Subject: Re: [PATCH] 2nd round of Mips ifunc support >=20 > On 16 November 2013 00:41, Jack Carter wrote: > > Attached is the second pass for Mips ifunc support in glibc. > > > > There is an abi attached as well. >=20 > Your patch would be easier to review if it was posted inline with e.g. > git-send-email. Will do. I got reamed for using it for LLVM, but am learning the difference= s between the 2 cultures. >=20 > I don't think the vxworks comment in the commit message (or indeed the > reference to micromips etc.) makes any sense in the context of glibc. I will take them out.=20 >=20 > The use of __builtin_expect should be replaced with __glibc_unlikely. I will make the changes. >=20 > The example in your ABI doc should probably take an argument of the > hwcap value rather than void. I will make the changes. >=20 > -- > Will Newton > Toolchain Working Group, Linaro