From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23990 invoked by alias); 26 Nov 2010 16:45:18 -0000 Received: (qmail 23971 invoked by uid 22791); 26 Nov 2010 16:45:16 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from a.mail.sonic.net (HELO a.mail.sonic.net) (64.142.16.245) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Nov 2010 16:45:11 +0000 Received: from are.twiddle.net (are.twiddle.net [75.101.38.216]) by a.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id oAQGj3xr012384 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 26 Nov 2010 08:45:04 -0800 Received: from anchor.twiddle.home (anchor.twiddle.home [172.31.0.4]) by are.twiddle.net (8.14.4/8.14.4) with ESMTP id oAQGj0xx017772; Fri, 26 Nov 2010 08:45:00 -0800 Message-ID: <4CEFE40C.5040807@twiddle.net> Date: Fri, 26 Nov 2010 16:45:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Thunderbird/3.1.6 MIME-Version: 1.0 To: Matt Turner CC: libc-ports@sourceware.org, "Maciej W. Rozycki" , andrew.pinski@caviumnetworks.com Subject: Re: MIPS: getpagesize, PAGE_SHIFT, and PAGE_SIZE References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00018.txt.bz2 On 11/23/2010 12:24 PM, Matt Turner wrote: > Can someone explain what having __ASSUME_AT_PAGESIZE defined actually > means? Is it correct that it's defined on MIPS? If so, can't we just > #include the generic Linux implementation instead of ia64, or better > yet, just delete MIPS' getpagesize.c? _ASSUME_AT_PAGESIZE means "assume the kernel has included the AT_PAGESZ entry in the auxv area that lives above argc+argv+env at program start". Given that this entry is added by generic code in binfmt_elf.c, yes it is correct that it's defined on MIPS. > Also, PAGE_SHIFT (and by extension PAGE_SIZE) are defined as constants > on MIPS. This is clearly wrong, as MIPS supports multiple pagesizes. > What can we do about this? Delete the relevant entries? That's what ia64, sparc, powerpc seem to do. r~