Re: [PATCH v2 1b/10] sysdeps/unix/sysv/linux/tile support

[Chris Metcalf <cmetcalf@tilera.com>]

On 11/14/2011 7:06 PM, Joseph S. Myers wrote:
> On Thu, 10 Nov 2011, Chris Metcalf wrote:
>
>> +/* TILE glibc support starts with 2.6.36, guaranteeing many kernel features. */
> It occurs to me that you ought also to have arch_minimum_kernel=2.6.36 in 
> sysdeps/unix/sysv/linux/tile/configure.in or similar (like that in 
> sysdeps/unix/sysv/linux/arm/eabi/configure.in, for example).

Thanks, I'll do that.

> And if you 
> do that, then some of the __ASSUME_* definitions may no longer be needed 
> because the architecture-independent version of kernel-features.h would 
> provide them.

There are a number of __ASSUME features that don't become automatically
enabled for random architectures no matter what the kernel version; they
are guarded with tests for i386, sparc, powerpc, etc.  Arguably we could
fix this by modifying sysdeps/unix/sysv/linux/kernel-features.h directly,
but it's probably reasonable to leave this stuff in the "generic" ports
tree.  I only set the ones that weren't otherwise being set by stating a
kernel version of 2.6.36.

> OK with that change.

Thanks for the sign-off on this and the other ports changes!

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com