From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24256 invoked by alias); 15 Nov 2011 03:32:56 -0000 Received: (qmail 24244 invoked by uid 22791); 15 Nov 2011 03:32:54 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (206.83.70.75) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Nov 2011 03:32:40 +0000 Received: from [192.168.1.104] (24.34.76.130) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server id 14.0.694.0; Mon, 14 Nov 2011 22:32:40 -0500 Message-ID: <4EC1DD56.2070506@tilera.com> Date: Tue, 15 Nov 2011 03:32:00 -0000 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: "Joseph S. Myers" CC: Subject: Re: [PATCH v2 1b/10] sysdeps/unix/sysv/linux/tile support References: <201111100054.pAA0sf6u025585@farm-0002.internal.tilera.com> <201111100435.pAA4ZuEh008673@farm-0002.internal.tilera.com> <4EBB5F2D.2060301@tilera.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00046.txt.bz2 On 11/14/2011 7:06 PM, Joseph S. Myers wrote: > On Thu, 10 Nov 2011, Chris Metcalf wrote: > >> +/* TILE glibc support starts with 2.6.36, guaranteeing many kernel features. */ > It occurs to me that you ought also to have arch_minimum_kernel=2.6.36 in > sysdeps/unix/sysv/linux/tile/configure.in or similar (like that in > sysdeps/unix/sysv/linux/arm/eabi/configure.in, for example). Thanks, I'll do that. > And if you > do that, then some of the __ASSUME_* definitions may no longer be needed > because the architecture-independent version of kernel-features.h would > provide them. There are a number of __ASSUME features that don't become automatically enabled for random architectures no matter what the kernel version; they are guarded with tests for i386, sparc, powerpc, etc. Arguably we could fix this by modifying sysdeps/unix/sysv/linux/kernel-features.h directly, but it's probably reasonable to leave this stuff in the "generic" ports tree. I only set the ones that weren't otherwise being set by stating a kernel version of 2.6.36. > OK with that change. Thanks for the sign-off on this and the other ports changes! -- Chris Metcalf, Tilera Corp. http://www.tilera.com