From: Chris Metcalf <cmetcalf@tilera.com>
To: Roland McGrath <roland@hack.frob.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH] linux-generic: avoid "redefined" warnings for open_not_cancel{,_2}
Date: Tue, 15 May 2012 20:50:00 -0000 [thread overview]
Message-ID: <4FB2C174.7020601@tilera.com> (raw)
In-Reply-To: <20120515204606.037152C063@topped-with-meat.com>
On 5/15/2012 4:46 PM, Roland McGrath wrote:
>> Fair enough, but my concern was: what guard? Should I be very explicit and use
>>
>> #ifndef _SYSDEPS_UNIX_SYSV_LINUX_GENERIC_NOT_CANCEL_H
>> # define _SYSDEPS_UNIX_SYSV_LINUX_GENERIC_NOT_CANCEL_H
>> ...
>> #endif
> That is OK but we've usually been not quite so verbose and just use a name
> that is sufficiently unique, e.g. _LINUX_GENERIC_NOT_CANCEL_H.
OK, I'll commit the obvious change using that name. Thanks.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
prev parent reply other threads:[~2012-05-15 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 20:20 Chris Metcalf
2012-05-15 20:23 ` Roland McGrath
2012-05-15 20:38 ` Chris Metcalf
2012-05-15 20:46 ` Roland McGrath
2012-05-15 20:50 ` Chris Metcalf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB2C174.7020601@tilera.com \
--to=cmetcalf@tilera.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).