From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-2645-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 26288 invoked by alias); 15 May 2012 20:50:11 -0000
Received: (qmail 26280 invoked by uid 22791); 15 May 2012 20:50:10 -0000
X-SWARE-Spam-Status: No, hits=-3.0 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 May 2012 20:49:57 +0000
Received: from [10.7.0.95] (10.9.0.23) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server id 14.0.694.0; Tue, 15 May 2012 16:49:56 -0400
Message-ID: <4FB2C174.7020601@tilera.com>
Date: Tue, 15 May 2012 20:50:00 -0000
From: Chris Metcalf <cmetcalf@tilera.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: Roland McGrath <roland@hack.frob.com>
CC: <libc-ports@sourceware.org>
Subject: Re: [PATCH] linux-generic: avoid "redefined" warnings for open_not_cancel{,_2}
References: <201205152020.q4FKKcxp014005@farm-0002.internal.tilera.com> <20120515202251.3C6D72C0A2@topped-with-meat.com> <4FB2BE9F.1090307@tilera.com> <20120515204606.037152C063@topped-with-meat.com>
In-Reply-To: <20120515204606.037152C063@topped-with-meat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00084.txt.bz2

On 5/15/2012 4:46 PM, Roland McGrath wrote:
>> Fair enough, but my concern was: what guard?  Should I be very explicit and use
>>
>> #ifndef _SYSDEPS_UNIX_SYSV_LINUX_GENERIC_NOT_CANCEL_H
>> # define _SYSDEPS_UNIX_SYSV_LINUX_GENERIC_NOT_CANCEL_H
>> ...
>> #endif
> That is OK but we've usually been not quite so verbose and just use a name
> that is sufficiently unique, e.g. _LINUX_GENERIC_NOT_CANCEL_H.

OK, I'll commit the obvious change using that name.  Thanks.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com