From: Chris Metcalf <cmetcalf@tilera.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [PATCH] tilegx: provide a setxid.h to handle negative uids
Date: Fri, 18 May 2012 17:05:00 -0000 [thread overview]
Message-ID: <4FB68155.5000109@tilera.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1205172317340.28988@digraph.polyomino.org.uk>
On 5/17/2012 7:20 PM, Joseph S. Myers wrote:
> On Thu, 17 May 2012, Chris Metcalf wrote:
>
>> We observed a bug where setreuid(-1, -1) was becoming
>> setreuid(4294967295, 4294967295) instead, and therefore failing,
>> instead of doing nothing and returning success.
> For MIPS there was such an issue but it was concluded that it was a kernel
> bug and the kernel should properly extend syscall arguments passed from
> userspace; see the references in bug 4459. Is tilegx doing things
> differently from that?
Thanks for the pointer. Some searching around tracked it down the
SYSCALL_WRAPPERS config option, which I've now enabled for tilegx, and
which appears to do exactly the right thing in terms of handling sub-word
size arguments. I'll see if I can push it to 3.4 and to -stable.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2012-05-18 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 20:54 Chris Metcalf
2012-05-17 23:21 ` Joseph S. Myers
2012-05-18 17:05 ` Chris Metcalf [this message]
2012-05-22 13:28 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB68155.5000109@tilera.com \
--to=cmetcalf@tilera.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).