From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32052 invoked by alias); 27 Jul 2012 20:58:50 -0000 Received: (qmail 32028 invoked by uid 22791); 27 Jul 2012 20:58:49 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,SARE_SUB_GETRID,TW_BJ,TW_FC X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Jul 2012 20:58:36 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SurcF-0001GW-Qy from Carlos_ODonell@mentor.com ; Fri, 27 Jul 2012 13:58:31 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 27 Jul 2012 13:58:31 -0700 Received: from [172.30.4.45] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Fri, 27 Jul 2012 13:58:30 -0700 Message-ID: <501300F6.4060608@mentor.com> Date: Fri, 27 Jul 2012 20:58:00 -0000 From: Carlos O'Donell User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Roland McGrath CC: Marek Polacek , , libc-ports , Kaz Kojima , Andreas Krebbel , David Miller Subject: Re: [PATCH] Get rid of ASM_TYPE_DIRECTIVE{,_PREFIX} References: <20120727191849.GJ3311@redhat.com> <20120727202833.25E832C109@topped-with-meat.com> In-Reply-To: <20120727202833.25E832C109@topped-with-meat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00075.txt.bz2 On 7/27/2012 4:28 PM, Roland McGrath wrote: > I only skimmed but this all looks fine to me. For paranoia's sake, since > this should not change anything, please check that no code changed for i?86 > and x86_64 (eu-elfcmp might suffice, or else objdump -d comparisons). > It should still wait for at least two of sh, powerpc, s390 to report > testing ok. But since this is so mechanical and simple, I'd say if they > are slow (like past the middle of next week, say), commit it anyway and > just remind folks they still need to test. Agreed. Cheers, Carlos. -- Carlos O'Donell Mentor Graphics / CodeSourcery carlos_odonell@mentor.com carlos@codesourcery.com +1 (613) 963 1026