From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3673 invoked by alias); 2 Aug 2012 18:14:01 -0000 Received: (qmail 3648 invoked by uid 22791); 2 Aug 2012 18:14:00 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,TW_EG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Aug 2012 18:13:47 +0000 Received: from [10.7.0.95] (10.9.0.23) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server id 14.0.694.0; Thu, 2 Aug 2012 14:13:46 -0400 Message-ID: <501AC359.5070206@tilera.com> Date: Thu, 02 Aug 2012 18:14:00 -0000 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Roland McGrath CC: , Subject: Re: [PATCH roland/off64_t] clean up wordsize-64 off_t functions References: <20120802172110.E4A912C0DF@topped-with-meat.com> In-Reply-To: <20120802172110.E4A912C0DF@topped-with-meat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00013.txt.bz2 On 8/2/2012 1:21 PM, Roland McGrath wrote: > If there are any linux-generic configurations where off_t matches off64_t, > i.e. __SLONGWORD_TYPE matches __SQUAD_TYPE (tilegx64?), then that will need > some additional attention too. I'm not sure how best to handle that. > It would be nice not to add another bits/typesizes.h, but it may be > unavoidable unless every such machine predefines __LP64__ or something > like that. In trunk GCC it looks like that is done generically, but I > don't know if all relevant GCC versions did that. Yes, it's correct that tilegx64 has off_t == off64_t. I think using "#ifdef __LP64__" in ports/sysdeps/unix/sysv/linux/generic/bits/typesizes.h is a reasonable approach here; it's certainly true for tile that gcc supports __LP64__ that way, and since as you say it's generic in gcc, I think we can assume that any new platform that incorporates support for linux-generic will also properly support __LP64__. Alternately, I suppose, one could #include in and test __WORDSIZE == 64. But I don't think it's necessary. -- Chris Metcalf, Tilera Corp. http://www.tilera.com