From: Carlos O'Donell <carlos@systemhalted.org>
To: Roland McGrath <roland@hack.frob.com>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>, libc-ports@sourceware.org
Subject: Re: [PATCH roland/arm-hwcap-vfp] don't use HWCAP_ARM_* in OS-independent code
Date: Thu, 09 Aug 2012 17:21:00 -0000 [thread overview]
Message-ID: <5023F173.1040506@systemhalted.org> (raw)
In-Reply-To: <20120809171033.CC7D32C0FD@topped-with-meat.com>
On 8/9/2012 1:10 PM, Roland McGrath wrote:
>> __VFP_FP__ doesn't mean "generating VFP instructions", it means
>> "floating-point types have VFP layout" (i.e. normal IEEE floating-point
>> with the same byte ordering / endianness as integer types, as opposed to
>> FPA format), which is always true for EABI. The relevant test for
>> "generating VFP instructions" is defined __VFP_FP__ && !defined __SOFTFP__
>> (which can be simplified to just !defined __SOFTFP__ given that EABI is
>> assumed).
>
> Thanks for the explanation. I've changed the conditionals. On further
> reflection I also decided that using ldsodefs.h was just too ugly and I've
> added an arm-features.h instead.
>
> How does this look now?
>
>
> Thanks,
> Roland
>
>
> ports/ChangeLog.arm
> 2012-08-09 Roland McGrath <roland@hack.frob.com>
>
> * sysdeps/arm/arm-features.h: New file.
> * sysdeps/unix/sysv/linux/arm/arm-features.h: New file.
If we are going to make a new internal header for this kind of thing
can you please add a "Internal Headers" section in the "Internals Documentation"
part of the wiki and mention briefly "*-features.h" and when and why you might
use it?
http://sourceware.org/glibc/wiki/HomePage#InternalsDocumentation
Alternatively add this to manual/maint.texi please :-)
Cheers,
Carlos.
next prev parent reply other threads:[~2012-08-09 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 23:59 Roland McGrath
2012-08-09 11:16 ` Joseph S. Myers
2012-08-09 17:10 ` Roland McGrath
2012-08-09 17:21 ` Carlos O'Donell [this message]
2012-08-09 18:47 ` Joseph S. Myers
2012-08-09 18:50 ` Roland McGrath
2012-08-09 18:49 ` Joseph S. Myers
2012-08-09 19:44 ` Roland McGrath
2012-08-09 15:17 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5023F173.1040506@systemhalted.org \
--to=carlos@systemhalted.org \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).