public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org, David Miller <davem@davemloft.net>,
	 libc-ports@sourceware.org
Subject: Re: Make fma use of Dekker and Knuth algorithms use round-to-nearest (bug 14796)
Date: Tue, 06 Nov 2012 19:26:00 -0000	[thread overview]
Message-ID: <50996451.9070904@twiddle.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1211020212060.13462@digraph.polyomino.org.uk>

On 2012-11-01 19:14, Joseph S. Myers wrote:
> +      libc_feupdateenv (&env);
> +      /* Ensure that round-to-nearest value of z + m1 is not
> +	 reused.  */
> +      asm volatile ("" : "=m" (z) : "m" (z));

We have math_opt_barrier and math_force_eval.
We should use them and not spread more raw asms.

I know there are plenty of other existing instances
that should also be fixed, but we shouldn't add more.

Otherwise the actual logic looks ok.


r~

      parent reply	other threads:[~2012-11-06 19:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02  2:15 Joseph S. Myers
2012-11-02 21:24 ` David Miller
2012-11-03 19:15 ` David Miller
2012-11-06 19:26 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50996451.9070904@twiddle.net \
    --to=rth@twiddle.net \
    --cc=davem@davemloft.net \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libc-ports@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).