From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11104 invoked by alias); 5 Dec 2012 15:15:20 -0000 Received: (qmail 11092 invoked by uid 22791); 5 Dec 2012 15:15:19 -0000 X-SWARE-Spam-Status: No, hits=-3.0 required=5.0 tests=AWL,BAYES_00,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Dec 2012 15:15:11 +0000 Received: from [192.168.1.104] (24.34.76.130) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server id 14.0.694.0; Wed, 5 Dec 2012 10:15:10 -0500 Message-ID: <50BF64FC.9020000@tilera.com> Date: Wed, 05 Dec 2012 15:15:00 -0000 From: Chris Metcalf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: "Joseph S. Myers" CC: Subject: Re: Fix warnings from MIPS soft-float _FPU_GETCW References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00025.txt.bz2 On 12/4/2012 5:07 PM, Joseph S. Myers wrote: > Testing for MIPS soft-float showed up compile warnings ("statement > with no effect") in setfpucw.c arising from the soft-float definition > of _FPU_GETCW just being "0". I've applied this patch to make the > definition actually store 0 in cw, and correspondingly to make > _FPU_SETCW use cw by casting the value to (void), to make these > soft-float definitions better at avoiding warnings from use using > these macros. > > 2012-12-04 Joseph Myers > > * sysdeps/mips/fpu_control.h [__mips_soft_float] (_FPU_GETCW): > Define to set cw to 0, now just to plain "0" as a statement. > [__mips_soft_float] (_FPU_SETCW): Define to (void) (cw), rather > than doing nothing with cw. I see the same warning on tile, because we are using sysdeps/generic/fpu_control.h, which has the same issue. Do you want to fix that file as well as the mips one while you're at it? Or should I push that same fix? -- Chris Metcalf, Tilera Corp. http://www.tilera.com