From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32224 invoked by alias); 13 Jan 2013 19:32:44 -0000 Received: (qmail 32209 invoked by uid 22791); 13 Jan 2013 19:32:43 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from moutng.kundenserver.de (HELO moutng.kundenserver.de) (212.227.17.8) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 13 Jan 2013 19:32:38 +0000 Received: from [192.168.2.102] (p5DDB55A4.dip.t-dialin.net [93.219.85.164]) by mrelayeu.kundenserver.de (node=mreu4) with ESMTP (Nemesis) id 0Mccy4-1TcwPU0sE4-00HhOd; Sun, 13 Jan 2013 20:32:36 +0100 Message-ID: <50F30BB9.8090605@grapentin.org> Date: Sun, 13 Jan 2013 19:32:00 -0000 From: Andreas Grapentin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121129 Thunderbird/10.0.11 MIME-Version: 1.0 To: libc-ports@sourceware.org Subject: [PATCH] [SUGGESTION?] remove obsolete case statement in configure.in Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00015.txt.bz2 Hi, I'm currently in the process of understanding the build process of glibc, and during that I was reading, and trying to grasp the configure.in file. Am I correct, that the attached patch transforms a case with only one relevant branch into a (probably better to understand) if statement that makes more sense? Cheers, Andy diff --git a/configure.in b/configure.in index 16497fa..7c908cc 100644 --- a/configure.in +++ b/configure.in @@ -327,13 +327,9 @@ AC_ARG_ENABLE([nscd], # i486-pc-linux-gnu fully from i486-pc-gnu. So we mutate a $host_os # of `gnu*' here to be `gnu-gnu*' just so that shlib-versions can # tell. This doesn't get used much beyond that, so it's fairly safe. -case "$host_os" in -linux*) - ;; -gnu*) +if test "$host_os" = gnu*; then host_os=`echo $host_os | sed -e 's/gnu/gnu-gnu/'` - ;; -esac +fi # We keep the original values in `$config_*' and never modify them, so we # can write them unchanged into config.make. Everything else uses