From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-3694-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 3542 invoked by alias); 20 Feb 2013 16:25:40 -0000
Received: (qmail 3482 invoked by uid 22791); 20 Feb 2013 16:25:34 -0000
X-SWARE-Spam-Status: No, hits=-8.0 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Feb 2013 16:25:26 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1KGPO5k023725	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 20 Feb 2013 11:25:24 -0500
Received: from [10.3.113.139] (ovpn-113-139.phx2.redhat.com [10.3.113.139])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r1KGPMwi002373;	Wed, 20 Feb 2013 11:25:23 -0500
Message-ID: <5124F8F2.8030708@redhat.com>
Date: Wed, 20 Feb 2013 16:25:00 -0000
From: "Carlos O'Donell" <carlos@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: Thomas Schwinge <thomas@codesourcery.com>
CC: "Carlos O'Donell" <carlos@systemhalted.org>,        Richard Henderson <rth@twiddle.net>, libc-alpha@sourceware.org,        libc-ports@sourceware.org, joseph@codesourcery.com
Subject: Re: Usage of __attribute__used__ in (system) headers?
References: <87r4khnbqm.fsf@kepler.schwinge.homeip.net> <CAE2sS1hXkxSq_sr=ySEeaV99O5WOAmaygufmeGmwMuc2d+EnZw@mail.gmail.com> <51227F2E.5060103@twiddle.net> <CAE2sS1j8PQ=+LNCihphwr-RbxfNkRtB3xfOz9DmaQhp5x7kdOQ@mail.gmail.com> <87vc9nc6ma.fsf@schwinge.name>
In-Reply-To: <87vc9nc6ma.fsf@schwinge.name>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00051.txt.bz2

On 02/20/2013 11:06 AM, Thomas Schwinge wrote:
> ports/
> 	* sysdeps/mips/bits/nan.h [!__GNUC__] (__nan_union): Change
> 	__attribute_used__ to __attribute__ ((unused)).
> 
> diff --git ports/sysdeps/mips/bits/nan.h ports/sysdeps/mips/bits/nan.h
> index 71f372d..8f4666d 100644
> --- ports/sysdeps/mips/bits/nan.h
> +++ ports/sysdeps/mips/bits/nan.h
> @@ -50,7 +50,7 @@
>  # endif
>  
>  static union { unsigned char __c[4]; float __d; } __nan_union
> -    __attribute_used__ = { __nan_bytes };
> +  __attribute__ ((unused)) = { __nan_bytes };
>  # define NAN	(__nan_union.__d)
>  
>  #endif	/* GCC.  */
> diff --git sysdeps/ieee754/bits/nan.h sysdeps/ieee754/bits/nan.h
> index d3ab38b..a1e6a51 100644
> --- sysdeps/ieee754/bits/nan.h
> +++ sysdeps/ieee754/bits/nan.h
> @@ -46,7 +46,7 @@
>  # endif
>  
>  static union { unsigned char __c[4]; float __d; } __nan_union
> -    __attribute_used__ = { __nan_bytes };
> +  __attribute__ ((unused)) = { __nan_bytes };
>  # define NAN	(__nan_union.__d)
>  
>  #endif	/* GCC.  */

Please fix this to use __unused__.

We should not use attributes that are in the user's namespace.

Cheers,
Carlos.