From: "Carlos O'Donell" <carlos@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: "Carlos O'Donell" <carlos@systemhalted.org>,
Richard Henderson <rth@twiddle.net>,
libc-alpha@sourceware.org, libc-ports@sourceware.org,
joseph@codesourcery.com
Subject: Re: Usage of __attribute__used__ in (system) headers?
Date: Wed, 20 Feb 2013 18:02:00 -0000 [thread overview]
Message-ID: <51250F99.7090306@redhat.com> (raw)
In-Reply-To: <87mwuydg3w.fsf@schwinge.name>
On 02/20/2013 12:56 PM, Thomas Schwinge wrote:
> Hi!
>
> On Wed, 20 Feb 2013 11:25:22 -0500, Carlos O'Donell <carlos@redhat.com> wrote:
>>> static union { unsigned char __c[4]; float __d; } __nan_union
>>> - __attribute_used__ = { __nan_bytes };
>>> + __attribute__ ((unused)) = { __nan_bytes };
>
>> Please fix this to use __unused__.
>>
>> We should not use attributes that are in the user's namespace.
>
> Pushed as commit 50022a93fcc36a0130b9f882709ff69f4b91c0cc:
>
> * sysdeps/ieee754/bits/nan.h [!__GNUC__] (__nan_union): Change
> __attribute__ ((unused)) to __attribute__ ((__unused__)).
>
> ports/
> * sysdeps/mips/bits/nan.h [!__GNUC__] (__nan_union): Change
> __attribute__ ((unused)) to __attribute__ ((__unused__)).
Thanks!
Cheers,
Carlos.
prev parent reply other threads:[~2013-02-20 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87r4khnbqm.fsf@kepler.schwinge.homeip.net>
2013-02-18 19:00 ` Carlos O'Donell
2013-02-18 19:21 ` Richard Henderson
2013-02-18 19:41 ` Carlos O'Donell
2013-02-20 16:06 ` Thomas Schwinge
2013-02-20 16:25 ` Carlos O'Donell
2013-02-20 17:56 ` Thomas Schwinge
2013-02-20 18:02 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51250F99.7090306@redhat.com \
--to=carlos@redhat.com \
--cc=carlos@systemhalted.org \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=rth@twiddle.net \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).