From: "Carlos O'Donell" <carlos@redhat.com>
To: Andreas Jaeger <aj@suse.com>
Cc: Thomas Schwinge <thomas@codesourcery.com>,
libc-alpha@sourceware.org, libc-ports@sourceware.org,
munroesj@us.ibm.com, rsa@us.ibm.com,
joseph@codesourcery.com
Subject: Re: [PATCH] Better distinguish between NaN/qNaN/sNaN.
Date: Tue, 05 Mar 2013 21:14:00 -0000 [thread overview]
Message-ID: <51366028.9010903@redhat.com> (raw)
In-Reply-To: <51365EAF.80407@suse.com>
On 03/05/2013 04:07 PM, Andreas Jaeger wrote:
> On 03/05/2013 08:31 PM, Thomas Schwinge wrote:
>> In preparation for adding tests with sNaN inputs later on.
>>
>> * math/basic-test.c (TEST_FUNC, TEST_TRUNC): Rename NaN_var to
>> qNaN_var. Fix a few strings, too.
>> * math/libm-test.inc (nan_value): Rename to qnan_value.
>> * math/gen-libm-test.pl (%beautify): Adjust to that.
>> * math/bits/mathcalls.h (nan): Refer to qNaN instead of NaN.
>> * math/test-misc.c (main): Likewise.
>> * sysdeps/ieee754/bits/nan.h (__nan_bytes, __nan_union): Rename
>> to __qnan_bytes, and __qnan_union, respectively.
>> * ports/sysdeps/mips/bits/nan.h (__nan_bytes, __nan_union):
>> Likewise.
>> * stdio-common/tstdiomisc.c (nanval, lnanval): Rename to qnanval,
>> and lqnanval, respectively.
>> * sysdeps/powerpc/bits/fenv.h: Fix usage of NaN/qNaN/sNaN.
>> * sysdeps/powerpc/fpu/fenv_libc.h: Likewise.
>> * sysdeps/powerpc/fpu/test-powerpc-snan.c (TEST_FUNC): Likewise,
>> and rename NaN_var to qNaN_var, and SNaN_var to sNaN_var.
>
> this is fine,
Looks good to me also.
Cheers,
Carlos.
prev parent reply other threads:[~2013-03-05 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 19:32 Thomas Schwinge
2013-03-05 21:08 ` Andreas Jaeger
2013-03-05 21:14 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51366028.9010903@redhat.com \
--to=carlos@redhat.com \
--cc=aj@suse.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=munroesj@us.ibm.com \
--cc=rsa@us.ibm.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).