From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9422 invoked by alias); 6 Mar 2013 16:39:12 -0000 Received: (qmail 9360 invoked by uid 22791); 6 Mar 2013 16:39:11 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,FRT_OFFER2,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Mar 2013 16:39:04 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9F44FA3DDF; Wed, 6 Mar 2013 17:39:03 +0100 (CET) Message-ID: <5137711E.8010503@suse.com> Date: Wed, 06 Mar 2013 16:39:00 -0000 From: Andreas Jaeger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: "Joseph S. Myers" Cc: libc-ports@sourceware.org Subject: Re: [PATCH 5/6] Use bits/mman-linux.h for MIPS References: <1362512224-26951-1-git-send-email-aj@suse.de> <1362512224-26951-6-git-send-email-aj@suse.de> <3652367.0reEtX4Bp7@byrd> <5137652E.5010803@suse.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00057.txt.bz2 On 03/06/2013 05:33 PM, Joseph S. Myers wrote: > On Wed, 6 Mar 2013, Andreas Jaeger wrote: > >> Here's an updated patch, ok now? >> >> Andreas >> >> 2013-03-06 Andreas Jaeger >> >> * sysdeps/unix/sysv/linux/bits/mman-linux.h (MAP_ANONYMOUS): Allow >> definition via __MAP_ANONYMOUS. >> >> ChangeLog.mips: >> * sysdeps/unix/sysv/linux/mips/bits/mman.h: Remove all defines >> provided by bits/mman-linux.h and include . >> (__MAP_ANONYMOUS): Define. > > OK. In general I think defining __* names ought to be the right approach > for architectures with more substantial differences in the values as well, > so that the architecture-specific headers never need to concern themselves > with the feature-test macros that determine when to expose non-__* names > to the user. Yes, further cleanup steps are possible here. Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126