From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18587 invoked by alias); 11 Mar 2013 21:19:34 -0000 Received: (qmail 18577 invoked by uid 22791); 11 Mar 2013 21:19:33 -0000 X-SWARE-Spam-Status: No, hits=-9.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Mar 2013 21:19:30 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2BLJSll017336 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 Mar 2013 17:19:28 -0400 Received: from [10.3.113.159] (ovpn-113-159.phx2.redhat.com [10.3.113.159]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2BLJRTd012649; Mon, 11 Mar 2013 17:19:27 -0400 Message-ID: <513E4A5E.6020404@redhat.com> Date: Mon, 11 Mar 2013 21:19:00 -0000 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: Roland McGrath CC: Joseph Myers , libc-ports@sourceware.org Subject: Re: [PATCH roland/arm-unified] ARM: Convert string/ assembly to unified syntax. References: <20130311182236.CAA382C071@topped-with-meat.com> In-Reply-To: <20130311182236.CAA382C071@topped-with-meat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00099.txt.bz2 On 03/11/2013 02:22 PM, Roland McGrath wrote: > The assemblers I'm using give warnings about some code being in the older > syntax. This makes them happy. Verified that the assembled instructions > are unchanged. > > OK? > > > Thanks, > Roland > > > ports/ChangeLog.arm > * sysdeps/arm/memcpy.S: Convert to unified assembly syntax. > * sysdeps/arm/memmove.S: Likewise. > * sysdeps/arm/memset.S: Likewise. > * sysdeps/arm/strlen.S: Likewise. > > --- a/ports/sysdeps/arm/memcpy.S > +++ b/ports/sysdeps/arm/memcpy.S > @@ -53,6 +53,7 @@ > #endif > > .text > + .syntax unified All new code should really be using the unified syntax, I'm happy to see this change, and a quick check against my quick reference for unified syntax passes OK. When you verified the assembled instructions were unchanged did you look to see that the opcodes were the same or that disassembling the result yielded the same previously disassembled instructions? I say this just to make sure we didn't happen across any binutils bugs, which isn't uncommon in some of the less used encodings, or that the encodings changed and that they mean something else now. Cheers, Carlos.