From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-ports-return-3899-listarch-libc-ports=sources.redhat.com@sourceware.org>
Received: (qmail 8599 invoked by alias); 12 Mar 2013 14:06:30 -0000
Received: (qmail 8572 invoked by uid 22791); 12 Mar 2013 14:06:28 -0000
X-SWARE-Spam-Status: No, hits=-9.2 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 14:06:11 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2CE695m012684	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 12 Mar 2013 10:06:09 -0400
Received: from [10.3.113.38] (ovpn-113-38.phx2.redhat.com [10.3.113.38])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2CE66cU016031;	Tue, 12 Mar 2013 10:06:06 -0400
Message-ID: <513F364D.1080703@redhat.com>
Date: Tue, 12 Mar 2013 14:06:00 -0000
From: "Carlos O'Donell" <carlos@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3
MIME-Version: 1.0
To: Andreas Schwab <schwab@suse.de>
CC: Chris Metcalf <cmetcalf@tilera.com>, Roland McGrath <roland@hack.frob.com>,        libc-alpha@sourceware.org, libc-ports@sourceware.org
Subject: Re: [PATCH] Don't build .os objects of static-only-routines for extra libs
References: <mvmr4juw5y8.fsf@hawking.suse.de> <20130308215906.6B7A22C0A5@topped-with-meat.com> <mvmr4jmqnft.fsf@hawking.suse.de> <513DD75F.6020405@tilera.com> <mvmboaqqcrk.fsf@hawking.suse.de> <513DE784.2020504@tilera.com> <mvm7gleq9x7.fsf@hawking.suse.de> <mvmtxohnfgu.fsf_-_@hawking.suse.de>
In-Reply-To: <mvmtxohnfgu.fsf_-_@hawking.suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-ports.sourceware.org>
List-Subscribe: <mailto:libc-ports-subscribe@sourceware.org>
List-Post: <mailto:libc-ports@sourceware.org>
List-Help: <mailto:libc-ports-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: libc-ports-owner@sourceware.org
X-SW-Source: 2013-03/txt/msg00111.txt.bz2

On 03/12/2013 05:18 AM, Andreas Schwab wrote:
> 	* extra-lib.mk (extra-objs): Add static-only-routines as .oS
> 	instead of .os.
> ---
>  extra-lib.mk | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/extra-lib.mk b/extra-lib.mk
> index a2293c5..247946f 100644
> --- a/extra-lib.mk
> +++ b/extra-lib.mk
> @@ -34,7 +34,12 @@ extra-objs += $(foreach o,$(filter-out .os .oS,$(object-suffixes-$(lib))),\
>  					   $($(lib)-shared-only-routines),\
>  					   $(all-$(lib)-routines))))
>  ifneq (,$(filter .os,$(object-suffixes-$(lib))))
> -extra-objs += $(all-$(lib)-routines:%=%.os)
> +extra-objs += $(patsubst %,%.os,$(filter-out $($(lib)-static-only-routines),\
> +					     $(all-$(lib)-routines)))
> +endif
> +ifneq (,$(filter .oS,$(object-suffixes-$(lib))))
> +extra-objs += $(patsubst %,%.oS,$(filter $($(lib)-static-only-routines),\
> +					 $(all-$(lib)-routines)))
>  endif
>  alltypes-$(lib) := $(foreach o,$(object-suffixes-$(lib)),\
>  			     $(objpfx)$(patsubst %,$(libtype$o),\
> 

Does this actually cause a problem building a library
using extra-lib.mk?

I'm trying to read the code and determine under which
conditions this would break one of the existing libraries
we build uding extra-lib.mk, but given my build logs it
looks like 

I understand that this is a correctness issue, but I was
just wondering if it has any actual impact on our builds
today.

Cheers,
Carlos.