From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29303 invoked by alias); 14 Apr 2013 00:40:46 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 29286 invoked by uid 89); 14 Apr 2013 00:40:46 -0000 X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from mail-pb0-f47.google.com (HELO mail-pb0-f47.google.com) (209.85.160.47) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 14 Apr 2013 00:40:45 +0000 Received: by mail-pb0-f47.google.com with SMTP id rq13so1967384pbb.20 for ; Sat, 13 Apr 2013 17:40:43 -0700 (PDT) X-Received: by 10.68.232.42 with SMTP id tl10mr21845240pbc.72.1365900043923; Sat, 13 Apr 2013 17:40:43 -0700 (PDT) Received: from kosambp.local (c-69-181-125-41.hsd1.ca.comcast.net. [69.181.125.41]) by mx.google.com with ESMTPS id fa5sm14264988pbb.35.2013.04.13.17.40.42 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 13 Apr 2013 17:40:42 -0700 (PDT) Message-ID: <5169FB0B.8010907@gmail.com> Date: Sun, 14 Apr 2013 00:40:00 -0000 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Florian Weimer CC: libc-alpha , "libc-ports@sourceware.org" , kosaki.motohiro@gmail.com Subject: Re: [PATCH 1/4] __fdelt_chk: Removed range check References: <1365744803-19197-1-git-send-email-kosaki.motohiro@gmail.com> <1365744803-19197-2-git-send-email-kosaki.motohiro@gmail.com> <5167BADC.3090101@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00050.txt.bz2 (4/12/13 1:28 PM), KOSAKI Motohiro wrote: > On Fri, Apr 12, 2013 at 3:42 AM, Florian Weimer wrote: >> On 04/12/2013 07:33 AM, KOSAKI Motohiro wrote: >>> >>> +strong_alias (__fdelt_nochk, __fdelt_chk) >>> +strong_alias (__fdelt_nochk, __fdelt_warn) >> >> >> This change (which disables checking for existing compiled binaries) seems >> the wrong thing to do to me. >> >> I tend to agree that it might make sense to make fd_set fortification >> optional, but it should be enabled by default. Could you please change your >> patch so that it performs the checking by default, and preserves checking >> for applications which were compiled against pre-2.18 versions? > > Could you clarify why you think so? Because I proposed exact same approach > at first and Carlos disagreed it because he pointed out an application > shouldn't > crash when post-2.18 application link with pre-2.18 libraries. Now I > agreed him and > then I changed my patch. > > OK, I don't think it's impossible. However, I need to understand more. > At least Carlos > explained why and it seems reasonable request to me. After while thinking, I could implement better patch. I believe it fill you and Carlos's request. Could you take a look next spin? Thank you.