From: "Carlos O'Donell" <carlos@redhat.com>
To: Will Newton <will.newton@linaro.org>
Cc: libc-ports@sourceware.org, patches@linaro.org
Subject: Re: [PATCH v2] ARM: Add Cortex-A15 optimized NEON and VFP memcpy routines, with IFUNC.
Date: Wed, 17 Apr 2013 17:51:00 -0000 [thread overview]
Message-ID: <516EE108.2030501@redhat.com> (raw)
In-Reply-To: <516D18F0.4060009@linaro.org>
On 04/16/2013 02:25 AM, Will Newton wrote:
> +size_t
> +__libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
> + size_t max)
> +{
> + size_t i = 0;
> + int hwcap;
> +
> + hwcap = GLRO(dl_hwcap);
> +
> + IFUNC_IMPL (i, name, memcpy,
> + IFUNC_IMPL_ADD (array, i, memcpy, hwcap & HWCAP_ARM_NEON,
> + __memcpy_neon)
> + IFUNC_IMPL_ADD (array, i, memcpy, hwcap & HWCAP_ARM_VFPv3,
> + __memcpy_vfp)
> + IFUNC_IMPL_ADD (array, i, memcpy, 1, __memcpy_arm));
> +
> + return i;
> +}
If unaligned access is a requirement why not check for it here?
While unaligned access is virtually free on ARMv6 or higher it
is still possible for the U-bit to be disabled and for this to
crash on such systems.
Cheers,
Carlos.
next prev parent reply other threads:[~2013-04-17 17:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 9:25 Will Newton
2013-04-17 15:40 ` Richard Henderson
2013-04-17 15:53 ` Will Newton
2013-04-18 7:42 ` Richard Henderson
2013-04-18 7:47 ` Siddhesh Poyarekar
2013-04-18 7:54 ` Will Newton
2013-04-18 8:26 ` Siddhesh Poyarekar
2013-04-18 8:38 ` Will Newton
2013-04-18 17:58 ` Siddhesh Poyarekar
2013-04-22 8:27 ` Will Newton
2013-04-17 17:51 ` Carlos O'Donell [this message]
2013-04-18 8:01 ` Will Newton
2013-04-19 21:47 ` Joseph S. Myers
2013-04-22 8:32 ` Will Newton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516EE108.2030501@redhat.com \
--to=carlos@redhat.com \
--cc=libc-ports@sourceware.org \
--cc=patches@linaro.org \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).