From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9287 invoked by alias); 1 May 2013 02:25:28 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 9248 invoked by uid 89); 1 May 2013 02:25:27 -0000 X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 01 May 2013 02:25:27 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r412PPUq014423 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Apr 2013 22:25:25 -0400 Received: from [10.3.113.84] (ovpn-113-84.phx2.redhat.com [10.3.113.84]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r412POqe024627; Tue, 30 Apr 2013 22:25:24 -0400 Message-ID: <51807D13.9090706@redhat.com> Date: Wed, 01 May 2013 02:25:00 -0000 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: KOSAKI Motohiro CC: libc-alpha@sourceware.org, libc-ports@sourceware.org Subject: Re: [PATCH 1/5] __fdelt_chk: Removed range check References: <1365900451-19026-1-git-send-email-kosaki.motohiro@gmail.com> <1365900451-19026-2-git-send-email-kosaki.motohiro@gmail.com> In-Reply-To: <1365900451-19026-2-git-send-email-kosaki.motohiro@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00000.txt.bz2 On 04/13/2013 08:47 PM, KOSAKI Motohiro wrote: > Signed-off-by: KOSAKI Motohiro > --- > ChangeLog | 5 +++++ > debug/fdelt_chk.c | 8 +++----- > 2 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/ChangeLog b/ChangeLog > index 36efa0b..5311919 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2013-03-25 KOSAKI Motohiro > + > + * debug/fdelt_chk.c (__fdelt_chk): Removed range check > + and renamed to __fdelt_nochk. > + > 2013-04-11 Carlos O'Donell > > * math/libm-test.inc (cos_test): Fix PI/2 test. > diff --git a/debug/fdelt_chk.c b/debug/fdelt_chk.c > index d149476..6588be0 100644 > --- a/debug/fdelt_chk.c > +++ b/debug/fdelt_chk.c > @@ -19,11 +19,9 @@ > > > long int > -__fdelt_chk (long int d) > +__fdelt_nochk (long int d) > { > - if (d < 0 || d >= FD_SETSIZE) > - __chk_fail (); > - > return d / __NFDBITS; > } > -strong_alias (__fdelt_chk, __fdelt_warn) > +strong_alias (__fdelt_nochk, __fdelt_chk) > +strong_alias (__fdelt_nochk, __fdelt_warn) > Doesn't this mean that you will disable the runtime check for FD_SETSIZE for all existing binaries? That means that we would have to recompile all of the applications again in order to get checking again using the new symbols proposed in PATCH #2? This is not sufficiently conservative. We want it the other way around. A simple recompile of ruby should result in a ruby that no longer needs to disable _FORTIFY_SOURCE to work around FD_SETSIZE checks. Cheers, Carlos.