From: Richard Henderson <rth@twiddle.net>
To: Will Newton <will.newton@linaro.org>
Cc: libc-ports@sourceware.org, patches@linaro.org,
Roland McGrath <roland@hack.frob.com>
Subject: Re: [PATCH, v5] ARM: Add Cortex-A15 optimized NEON and VFP memcpy routines, with IFUNC.
Date: Wed, 01 May 2013 12:53:00 -0000 [thread overview]
Message-ID: <5181102B.8060006@twiddle.net> (raw)
In-Reply-To: <517FF73E.5020509@linaro.org>
On 2013-04-30 17:54, Will Newton wrote:
> +<http://www.gnu.org/licenses/>. */
> +
> +#define NO_THUMB
Please add a comment as to why NO_THUMB is being set. C.f. the other
uses of that macro within sysdeps/arm/. (It's the negative offsets
for memories as I recall, but that won't be obvious from this file.)
> + /* Jump directly into the sequence below at the correct offset. */
> + add pc, pc, tmp1, lsl #1
This is going to fail for NaCl, defining ARM_ALWAYS_BX. I'm not quite
sure all of what needs to be done to fix that. I'm sure Roland will
have some advice...
Perhaps the answer is "nothing" and NaCl should be vectored back to the
non-ifunc version of the code.
r~
next prev parent reply other threads:[~2013-05-01 12:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 16:54 Will Newton
2013-04-30 17:08 ` Joseph S. Myers
2013-05-01 9:11 ` Will Newton
2013-04-30 17:18 ` Roland McGrath
2013-05-01 15:26 ` Will Newton
2013-05-01 17:01 ` Roland McGrath
2013-05-01 18:43 ` Will Newton
2013-05-02 19:54 ` Roland McGrath
2013-05-01 12:53 ` Richard Henderson [this message]
2013-05-01 16:50 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5181102B.8060006@twiddle.net \
--to=rth@twiddle.net \
--cc=libc-ports@sourceware.org \
--cc=patches@linaro.org \
--cc=roland@hack.frob.com \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).